Skip to content

Facebook share button working #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grvsachdeva wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Facebook share button working #152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7385abf
Facebook share button working
grvsachdeva Oct 21, 2017
9f76523
URL updation according to Environment
grvsachdeva Oct 22, 2017
9dbe111
URL and gitignore update
grvsachdeva Oct 22, 2017
2f36c53
general link using helper
grvsachdeva Oct 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ DEPENDENCIES
webmock (~> 3.0)

RUBY VERSION
ruby 2.3.3p222
ruby 2.4.1p111
Copy link
Copy Markdown
Collaborator

@leesharma leesharma Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


BUNDLED WITH
1.15.4
4 changes: 4 additions & 0 deletions app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ def display_date(date)
date.to_formatted_s(:long_ordinal)
end

def wishlist_url(wishlist)
request.base_url+"/wishlists/#{wishlist.id}"
end
Copy link
Copy Markdown
Collaborator

@leesharma leesharma Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually built into Rails, so you can remove this method. As an added bonus, the pre-included method will match your app configuration without extra work (ex. with subdomains, ports, friendly urls/slugs, etc.)

Here's a section of the official Rails Guides talking about _path and _url helpers.


private

def current_user_pronouns(user, perspectives, capitalize: true)
Expand Down
11 changes: 3 additions & 8 deletions app/views/wishlists/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
<div class="container">
<h2>
<%= @wishlist.name %>

<% if Rails.env.production? %>
<% url_share = "https://project-playtime-staging.herokuapp.com/wishlists/#{@wishlist.id}" %>
<% else %>
<% url_share = "https://project-playtime-staging.herokuapp.com/wishlists/#{@wishlist.id}" %>
<% end %>

<%= social_share_button_tag("Are you a hero of play? #{@wishlist.name} needs your help!",:url => url_share,desc: "Are you a hero of play? #{@wishlist.name} needs your help!") %>
<%= social_share_button_tag("Are you a hero of play? #{@wishlist.name} needs your help!",
url: wishlist_url(@wishlist),
desc: "Are you a hero of play? #{@wishlist.name} needs your help!") %>
Copy link
Copy Markdown
Collaborator

@leesharma leesharma Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 I like how you broke this up into multiple lines. Much easier to read!

</h2>

<% if current_user.can_manage?(@wishlist) %>
Expand Down