Hide Cancel button for Fullfilled requests#5558
Open
stefannibrasil wants to merge 2 commits intorubyforgood:mainfrom
Open
Hide Cancel button for Fullfilled requests#5558stefannibrasil wants to merge 2 commits intorubyforgood:mainfrom
stefannibrasil wants to merge 2 commits intorubyforgood:mainfrom
Conversation
Cancelling a fulfilled request returns a validation error: "Status cannot be changed once fulfilled". Since fulfilled requests cannot be cancelled, to prevent raising an error, this commit hides the Cancel button for fulfilled requests.
stefannibrasil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5544
Description
Cancelling a fulfilled request returns a validation error: "Status cannot be changed once
fulfilled":
Since fulfilled requests cannot be cancelled, to prevent raising an error, this commit hides the Cancel button for fulfilled requests.
Type of change
How Has This Been Tested?
Locally and with automated tests:
fulfilled requests do not show the Cancel button
another request still shows the Cancel button