5563 - Replace policy spec stubs with real tests

spec/policies/fund_request_policy_spec.rb

@@ -1,7 +1,30 @@
 require "rails_helper"
 
 RSpec.describe FundRequestPolicy, type: :policy do
-  # TODO: Add tests for FundRequestPolicy
+  subject { described_class }
 
-  pending "add some tests for FundRequestPolicy"
+  let(:casa_admin) { build_stubbed(:casa_admin) }
+  let(:supervisor) { build_stubbed(:supervisor) }
+  let(:volunteer) { build_stubbed(:volunteer) }
+
+  # NOTE: this policy is intentionally open - new?/create? are unconditionally
+  # true, so there is no denied role. Access is constrained upstream by the
+  # controller (FundRequestsController#verify_casa_case).
+  permissions :new?, :create? do
+    it "permits casa_admins" do
+      expect(subject).to permit(casa_admin)
+    end
+
+    it "permits supervisors" do
+      expect(subject).to permit(supervisor)
+    end
+
+    it "permits volunteers" do
+      expect(subject).to permit(volunteer)
+    end
+
+    it "permits a nil user" do
+      expect(subject).to permit(nil)
+    end
+  end
 end

spec/policies/learning_hour_topic_policy_spec.rb

@@ -1,7 +1,23 @@
 require "rails_helper"
 
 RSpec.describe LearningHourTopicPolicy, type: :policy do
-  # TODO: Add tests for LearningHourTopicPolicy
+  subject { described_class }
 
-  pending "add some tests for LearningHourTopicPolicy"
+  let(:casa_admin) { build_stubbed(:casa_admin) }
+  let(:supervisor) { build_stubbed(:supervisor) }
+  let(:volunteer) { build_stubbed(:volunteer) }
+
+  permissions :new?, :create?, :edit?, :update? do
+    it "permits casa_admins" do
+      expect(subject).to permit(casa_admin)
+    end
+
+    it "does not permit supervisors" do
+      expect(subject).not_to permit(supervisor)
+    end
+
+    it "does not permit volunteers" do
+      expect(subject).not_to permit(volunteer)
+    end
+  end
 end

spec/policies/learning_hour_type_policy_spec.rb

@@ -1,7 +1,23 @@
 require "rails_helper"
 
 RSpec.describe LearningHourTypePolicy, type: :policy do
-  # TODO: Add tests for LearningHourTypePolicy
+  subject { described_class }
 
-  pending "add some tests for LearningHourTypePolicy"
+  let(:casa_admin) { build_stubbed(:casa_admin) }
+  let(:supervisor) { build_stubbed(:supervisor) }
+  let(:volunteer) { build_stubbed(:volunteer) }
+
+  permissions :new?, :create?, :edit?, :update? do
+    it "permits casa_admins" do
+      expect(subject).to permit(casa_admin)
+    end
+
+    it "does not permit supervisors" do
+      expect(subject).not_to permit(supervisor)
+    end
+
+    it "does not permit volunteers" do
+      expect(subject).not_to permit(volunteer)
+    end
+  end
 end

spec/policies/note_policy_spec.rb

@@ -1,7 +1,23 @@
 require "rails_helper"
 
 RSpec.describe NotePolicy, type: :policy do
-  # TODO: Add tests for NotePolicy
+  subject { described_class }
 
-  pending "add some tests for NotePolicy"
+  let(:casa_admin) { build_stubbed(:casa_admin) }
+  let(:supervisor) { build_stubbed(:supervisor) }
+  let(:volunteer) { build_stubbed(:volunteer) }
+
+  permissions :create?, :edit?, :update?, :destroy? do
+    it "permits casa_admins" do
+      expect(subject).to permit(casa_admin)
+    end
+
+    it "permits supervisors" do
+      expect(subject).to permit(supervisor)
+    end
+
+    it "does not permit volunteers" do
+      expect(subject).not_to permit(volunteer)
+    end
+  end
 end