Issue 647: change column name on sortable models #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJV333
changed the title
Collaborator
|
@RJV333 if you're willing to update httparty as part of this PR, that'd be great! as for the trix update, @jmilljr24 do you have thoughts on that? |
Collaborator
I already pushed and merged the gem update for both httparty and trix. Just need to merge main into this PR and the CI will pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
We have added the Positioning Gem
The default column name is :position. Update all sortable models to use this naming convention.
Used separate migrations for each updated table to keep these changes small, separate, reservable, and safer to deploy.