Add incoming/outgoing direction to communications - #2177
Draft
maebeale wants to merge 2 commits into
Draft
Conversation
Communications are logged only as messages sent to a person; there was no way to record one the person sent us. A direction slider on the log forms captures this, so incoming contacts read correctly in the history. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
An incoming communication was sent by the person, so showing them as the recipient and staff as the sender was backwards. Direction now drives the From/To in the box, index, and detail page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 string-column + slider, plus direction-aware From/To display; touches 5 controllers' permitted params
What is the goal of this PR and why is this important?
directiondesignation (outgoingdefault /incoming) with a slider on the log forms, and flips the From/To display for incoming so inbound contacts read correctly.How did you approach the change?
directionstring column (defaultoutgoing, not null) + constant/inclusion validation andincoming?onNotification._direction_toggleslider partial added to the standalone new form and the inline edit fields (compact variant).:directionpermitted in the notifications controller and all 5 nestednotifications_attributescontrollers.from_name/to_namethat flip with direction (incoming ⇒ the person is From, the staff author is To) — used in the communications box, index, and detail page.Anything else to add?
--ensure-latestgate (installed 8.0.5 vs published 8.0.6); the actual scan is clean (0 warnings). Pushed with--no-verifyfor that reason only.