WAIT: Stop flagging a "Facilitator" form title as differing from a facilitator affiliation#1874
Draft
maebeale wants to merge 1 commit into
Draft
WAIT: Stop flagging a "Facilitator" form title as differing from a facilitator affiliation#1874maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
…tor affiliation The title-comparison badge excluded facilitator affiliations from the match check, so a form whose position is literally "Facilitator" was flagged as differing even when the org already had a matching facilitator affiliation. Compare against all affiliations instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 📖 Read — light-logic: a one-line condition change with a covering test
What is the goal of this PR and why is this important?
The "Title differs from form" badge on the org-affiliations panel was firing even when the title matched. A form whose Position/title is literally "Facilitator" was flagged as differing from an org's existing facilitator affiliation, which is wrong and confusing for admins reviewing registrations.
How did you approach the change?
The comparison previously excluded facilitator affiliations (
role_affiliations) before checking for a match, so a facilitator-only org always looked mismatched. Now the submitted position is compared against all affiliations — a facilitator affiliation's title is already "Facilitator", so it matches correctly viacasecmp?. Added a request spec covering the facilitator/"Facilitator" match case (written failing-first).UI Testing Checklist
Anything else to add?
No data or schema changes.