Skip to content

WAIT: Wire recipients, staff, shout-outs to affiliation helpers#1868

Open
maebeale wants to merge 1 commit into
maebeale/scholarships-page-fieldsfrom
maebeale/scholarships-page-wiring
Open

WAIT: Wire recipients, staff, shout-outs to affiliation helpers#1868
maebeale wants to merge 1 commit into
maebeale/scholarships-page-fieldsfrom
maebeale/scholarships-page-wiring

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

🤖 PR, suggested 👤 review level: 📖 Read — light-logic: view/service wiring onto existing model helpers, no migrations

Stacked on #1757 (Person read helpers). Review/merge that first — this PR's diff is shown against that branch.

What is the goal of this PR and why is this important?

  • Use the new Person#facilitator_organization / #job_affiliation / #facilitator_affiliation helpers for display, replacing the ad-hoc affiliation filtering on the event recipients/staff pages and the shout-out credit.

How did you approach the change?

  • Recipients header: program org + its city/state (facilitator side) + job title (job side); preload affiliations → organization → addresses so the new city/state cell adds no per-row queries.
  • Staff cards: real-job org, gracefully falling back to the facilitator org when there's no separate job affiliation.
  • Shout-out credit: real job → facilitator role → the org snapshotted on the registration.

UI Testing Checklist

  • events/:id/scholarships: each recipient shows program org (linked) + city/state + real-job title (not "Facilitator").
  • events/:id/staff: each card shows the real-job org, or the facilitator org when there's no job affiliation.
  • "Shout outs" credits the real-job org, falling back to facilitator org, then the registration's org.

Anything else to add?

Consume Person#facilitator_organization / #job_affiliation /
#facilitator_affiliation for display, replacing the ad-hoc affiliation
filtering on these pages:

- Recipients header: program org + its city/state (facilitator side) and the
  job title (job side); preload affiliations → organization → addresses so the
  new city/state cell adds no per-row queries.
- Staff cards: real-job org, falling back to the facilitator org.
- Shout-out credit: real job → facilitator role → the org snapshotted on the
  registration.

Stacked on the helpers PR (Person read accessors).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@maebeale maebeale marked this pull request as ready for review June 22, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant