WAIT: Wire recipients, staff, shout-outs to affiliation helpers#1868
Open
maebeale wants to merge 1 commit into
Open
WAIT: Wire recipients, staff, shout-outs to affiliation helpers#1868maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
Consume Person#facilitator_organization / #job_affiliation / #facilitator_affiliation for display, replacing the ad-hoc affiliation filtering on these pages: - Recipients header: program org + its city/state (facilitator side) and the job title (job side); preload affiliations → organization → addresses so the new city/state cell adds no per-row queries. - Staff cards: real-job org, falling back to the facilitator org. - Shout-out credit: real job → facilitator role → the org snapshotted on the registration. Stacked on the helpers PR (Person read accessors). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR, suggested 👤 review level: 📖 Read — light-logic: view/service wiring onto existing model helpers, no migrations
What is the goal of this PR and why is this important?
Person#facilitator_organization/#job_affiliation/#facilitator_affiliationhelpers for display, replacing the ad-hoc affiliation filtering on the event recipients/staff pages and the shout-out credit.How did you approach the change?
affiliations → organization → addressesso the new city/state cell adds no per-row queries.UI Testing Checklist
events/:id/scholarships: each recipient shows program org (linked) + city/state + real-job title (not "Facilitator").events/:id/staff: each card shows the real-job org, or the facilitator org when there's no job affiliation.Anything else to add?