Skip to content

HOLD: Use "Submit" label on /new form buttons #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maebeale wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

HOLD: Use "Submit" label on /new form buttons #1863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd029d
Use "Submit" label on /new form buttons
maebeale Jun 22, 2026
8e48aaa
Use "Submit" label on event registration new form
maebeale Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/allocations/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
</div>
<%= f.input :amount_dollars, label: "Amount ($)", input_html: { min: 0, step: 0.01, placeholder: "0.00", data: { controller: "currency-input", action: "currency-input#format" } } %>
<div class="mt-6">
<%= f.button :submit, "Create Allocation", class: "btn btn-primary" %>
<%= f.button :submit, "Submit", class: "btn btn-primary" %>
<% if source.present? %>
<%= link_to "Cancel", payment_path(source), class: "btn btn-secondary-outline ml-2" %>
<% else %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/event_registrations/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@

<div class="ml-auto flex items-center gap-3">
<%= link_to "Cancel", cancel_path, class: "btn btn-secondary-outline" %>
<%= f.button :submit, f.object.persisted? ? "Save changes" : "Create registration", class: "btn btn-primary" %>
<%= f.button :submit, f.object.persisted? ? "Save changes" : "Submit", class: "btn btn-primary" %>

@maebeale maebeale Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 From Claude: This partial is shared by new and edit, so only the non-persisted branch changes to "Submit" — the edit label ("Save changes") is intentionally preserved.

</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/forms/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@

<div class="bg-white border border-gray-200 rounded-xl shadow-sm p-6">
<div class="flex items-center gap-3">
<%= f.submit "Create form", class: "btn btn-primary cursor-pointer" %>
<%= f.submit "Submit", class: "btn btn-primary cursor-pointer" %>
<%= link_to "Cancel", forms_path, class: "btn btn-secondary-outline" %>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/payments/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@
<%= f.input :check_number, input_html: { class: "bg-white" } %>
<%= f.input :memo, label: "Memo", input_html: { class: "bg-white", placeholder: "Memo line on the check" } %>
<% end %>
<div class="mt-6"><%= f.button :submit, "Create Payment", class: "btn btn-primary" %><%= link_to "Cancel", payments_path, class: "btn btn-secondary-outline ml-2" %></div>
<div class="mt-6"><%= f.button :submit, "Submit", class: "btn btn-primary" %><%= link_to "Cancel", payments_path, class: "btn btn-secondary-outline ml-2" %></div>
<% end %>
</div>
2 changes: 1 addition & 1 deletion app/views/refunds/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@

<%= f.input :amount_dollars, label: "Amount ($)", input_html: { min: 0, step: 0.01, placeholder: "0.00", data: { controller: "currency-input", action: "currency-input#format" } } %>
<div class="mt-6">
<%= f.button :submit, @payment.is_a?(ExternalProcessorPayment) ? "Refund via Stripe" : "Create Refund", class: "btn btn-primary" %>
<%= f.button :submit, @payment.is_a?(ExternalProcessorPayment) ? "Refund via Stripe" : "Submit", class: "btn btn-primary" %>
<% if @payment.present? %>
<%= link_to "Cancel", payment_path(@payment), class: "btn btn-secondary ml-2" %>
<% else %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/scholarships/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,6 @@

<div class="ml-auto flex items-center gap-3">
<%= link_to "Cancel", cancel_path, class: "btn btn-secondary-outline" %>
<%= f.submit f.object.persisted? ? "Save changes" : "Create scholarship", class: "btn btn-primary" %>
<%= f.submit f.object.persisted? ? "Save changes" : "Submit", class: "btn btn-primary" %>
</div>
</div>