HOLD: Show allocated/amount-due stats on grant-funded scholarship edit#1860
Draft
maebeale wants to merge 1 commit into
Draft
HOLD: Show allocated/amount-due stats on grant-funded scholarship edit#1860maebeale wants to merge 1 commit into
maebeale wants to merge 1 commit into
Conversation
Grant-funded scholarships had no event, so they lost the at-a-glance budget stats that event-funded scholarships show. Surface the pending scholarship amount split across "Allocated" and "Amount due" so staff can see disbursement status without saving, mirroring the event flow. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
maebeale
commented
Jun 22, 2026
| renderGrantSplit(amountCents) { | ||
| if (!this.grantFundedValue) return | ||
|
|
||
| const completed = this.hasCompletedTarget && this.completedTarget.checked |
Collaborator
Author
There was a problem hiding this comment.
🤖 From Claude: HOLD point — for grant-funded scholarships I gate "Allocated" on tasks_completed (allocated once tasks are done, otherwise still due). The event side on main no longer gates allocation on this toggle, so the two flows differ. Want product confirmation before marking ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes [link an issue or remove this line]
What is the goal of this PR and why is this important?
How did you approach the change?
scholarships/_form, reusing the event card styling.scholarship_preview_controllerwith agrantFundedpath so the cards live-update as the amount and the "Tasks completed" toggle change; allocated counts once tasks are completed, the remainder is shown as due.main, which had substantially redesigned the scholarship form (new controller API, grant section split out); reconciled the feature onto the new structure.Anything else to add?
tasks_completed(allocated once tasks are done, otherwise due). On the event side,mainno longer gates allocation ontasks_completed— the toggle is informational. Want to confirm the grant-funded labels/behavior before marking ready.