-
Notifications
You must be signed in to change notification settings - Fork 24
HOLD: Import stories from a WordPress export CSV with an admin preview UI #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maebeale
wants to merge
2
commits into
main
Choose a base branch
from
maebeale/csv-story-importer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| class StoryImportsController < ApplicationController | ||
| # Admin-only flow for importing stories from a WordPress Posts Export CSV. | ||
| # | ||
| # new → upload form | ||
| # create → dry-run preview of what would be created (nothing written) | ||
| # confirm → run the real import against the stashed file | ||
| # | ||
| # The uploaded CSV is stashed as an ActiveStorage blob between the preview | ||
| # and confirm steps (it is too large for the cookie session). The blob is | ||
| # purged once the import runs. | ||
|
|
||
| def new | ||
| authorize! Story, to: :import? | ||
| end | ||
|
|
||
| def create | ||
| authorize! Story, to: :import? | ||
|
|
||
| file = params[:file] | ||
| return redirect_to(new_story_import_path, alert: "Choose a CSV file to import.") if file.blank? | ||
| return redirect_to(new_story_import_path, alert: "That file is not a CSV.") unless csv?(file) | ||
|
|
||
| @filename = file.original_filename | ||
| @blob = ActiveStorage::Blob.create_and_upload!( | ||
| io: file.open, filename: @filename, content_type: "text/csv" | ||
| ) | ||
| @result = run_import(file.path, dry_run: true) | ||
| render :create | ||
| rescue CSV::MalformedCSVError, ArgumentError => e | ||
| @blob&.purge | ||
| redirect_to new_story_import_path, alert: "Could not read that CSV: #{e.message}" | ||
| end | ||
|
|
||
| def confirm | ||
| authorize! Story, to: :import? | ||
|
|
||
| blob = ActiveStorage::Blob.find_signed!(params[:signed_id]) | ||
| result = blob.open { |tempfile| run_import(tempfile.path, dry_run: false) } | ||
| blob.purge | ||
|
|
||
| redirect_to stories_path, notice: import_notice(result) | ||
| rescue ActiveSupport::MessageVerifier::InvalidSignature, ActiveRecord::RecordNotFound | ||
| redirect_to new_story_import_path, | ||
| alert: "That upload is no longer available — please choose the file again." | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def run_import(path, dry_run:) | ||
| StoryImporter.new(csv_path: path, import_user: current_user, dry_run: dry_run).call | ||
| end | ||
|
|
||
| def csv?(file) | ||
| file.original_filename.to_s.downcase.end_with?(".csv") || | ||
| file.content_type.to_s.in?(%w[text/csv application/csv application/vnd.ms-excel]) | ||
| end | ||
|
|
||
| def import_notice(result) | ||
| "Import complete — #{result.ideas_created} story ideas and " \ | ||
| "#{result.stories_created} connected stories created" \ | ||
| "#{" (#{result.skipped.size} rows skipped)" if result.skipped.any?}." | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 From Claude: The CSV is ~1MB, so it is stashed as an ActiveStorage blob between preview and confirm rather than the cookie session. The blob is purged in
confirmonce the import runs; an abandoned preview leaves an orphan blob — open to a periodic sweep if that matters.