Fix reset-password Turbo session race#1492
Open
alceops wants to merge 2 commits intorubyforgood:mainfrom
Open
Conversation
Collaborator
|
Thanks for taking a look at this. Devise supports Turbo out of the box so this still doesn't fully address the root cause within this application. I'm not opposed to disabling turbo selectively but for something with clear support from Devise, I'm wondering what we are missing in this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-turbo="false"on the whole formFixes #1473
Verification
git diff --checkdata: { turbo: false }and the system spec checks submitter-level opt-outVerification limits