Fix MissingTemplate error for non-HTML home page requests#1337
Closed
Fix MissingTemplate error for non-HTML home page requests#1337
Conversation
…page Bots/crawlers requesting text/plain or other non-HTML formats caused a 500 error because no text template exists. Wrapping in respond_to returns 406 Not Acceptable for unsupported formats instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by #1339 which includes this fix plus robots.txt and rack-attack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Accept: text/plain) cause a 500 error (ActionView::MissingTemplate) because onlyindex.html.erbexistsrespond_toso unsupported formats get a406 Not Acceptableinstead of a 500How did you approach the change?
respond_toblock inHomeController#indexto explicitly handle onlyformat.htmlAnything else to add?
rescue_from ActionView::MissingTemplateinApplicationControllerto handle all cases🤖 Generated with Claude Code