HOLD: Titleize windows type short_names

[maebeale]

What is the goal of this PR and why is this important?

• Windows type short_names were stored as all-caps (ADULT, CHILDREN, COMBINED) which looked harsh in the UI
• Production data has already been updated to title case — this aligns the codebase to match

How did you approach the change?

• Updated db/seeds.rb and db/seeds/dummy_dev_seeds.rb
• Updated controller lookups that reference short_name by string (e.g. find_by(short_name: "Adult"))
• Updated rake task (story_data.rake)
• Updated factory traits (:adult, :children, :combined)
• Updated view specs, request specs, system tests, and model spec expectations

UI Testing Checklist

• Verify windows type names display as "Adult", "Children", "Combined" (not all-caps) across the app
• Run seeds successfully: bin/rails db:seed
• All specs pass: bundle exec rspec

Anything else to add?

• No migration needed — production data was already updated directly
• This is a codebase alignment change to match what's already in production

🤖 Generated with Claude Code