HOLD: Restrict ended events to registered users and grey out cards

[maebeale]

What is the goal of this PR and why is this important?

• Ended events were visible to all users on the events index, even if they never registered
• Users should only see ended events if they had an active registration (registered, attended, incomplete_attendance)
• Ended event cards should be visually distinct so users can tell at a glance

How did you approach the change?

Policy (EventPolicy):

• show? now checks ended? — only admins and actively registered users can view ended events via direct URL
• relation_scope for authenticated users uses a manual LEFT OUTER JOIN filtered to active registration statuses, with end_date >= now for upcoming events OR people.id = person_id for registered events
• relation_scope for unauthenticated users adds end_date >= now filter to exclude all ended events

Card styling (_card.html.erb):

• Uses class_names with conditional classes: ended events get bg-gray-100 border-gray-300 opacity-60, active events keep bg-white border-gray-200 hover:shadow-md

Tests:

• Added :ended factory trait
• Added 4 show? tests for ended events (admin, registered, unregistered, unauthenticated)
• Updated relation_scope tests to verify end_date and active status filtering

UI Testing Checklist

• Verify ended events only appear in index for users who registered
• Verify ended event cards appear greyed out (opacity-60, bg-gray-100)
• Verify non-ended events display normally (white bg, hover shadow)
• Verify admins can still see all events including ended
• Verify direct URL to ended event redirects unregistered users
• Verify "Event ended" text still displays on cards and show page

Anything else to add?

• The existing _registration_section.html.erb already showed "Event ended" text — no changes needed there
• Cancelled/no-show registrations do not grant visibility to ended events (only active statuses)

🤖 Generated with Claude Code