Skip to content

HOLD: Test workshop log colleague visibility and person dropdown scoping#1327

Open
maebeale wants to merge 1 commit intomainfrom
maebeale/colleague-workshop-logs
Open

HOLD: Test workshop log colleague visibility and person dropdown scoping#1327
maebeale wants to merge 1 commit intomainfrom
maebeale/colleague-workshop-logs

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Mar 3, 2026

What is the goal of this PR and why is this important?

  • Adds test coverage for workshop log index page scoping by organization affiliation
  • Verifies that the person dropdown follows the same affiliation rules as the organization dropdown
  • Ensures non-admin users only see colleague logs and colleague names from their affiliated organizations

How did you approach the change?

  • Added "colleague workshop log visibility" context with two specs:
    • Logs from colleagues in the same org are visible
    • Logs from unaffiliated orgs are hidden
  • Added "person filtering" context with two specs:
    • Person dropdown shows only affiliated colleagues for non-admins
    • Person dropdown shows all people with access for admins
  • No code changes needed — existing policy scopes already enforce the correct behavior

Anything else to add?

  • All 17 request specs pass (15 existing + 2 pending xits unchanged)

🤖 Generated with Claude Code

…liation

Adds request specs verifying that the workshop log index:
- Shows logs from colleagues in the same affiliated organization
- Hides logs from unaffiliated organizations
- Scopes the person dropdown to affiliated colleagues for non-admins
- Shows all people with access for admins

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@maebeale maebeale changed the title Test workshop log colleague visibility and person dropdown scoping HOLD: Test workshop log colleague visibility and person dropdown scoping Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant