HOLD: Delete legacy migration code and unused files#1290
Open
HOLD: Delete legacy migration code and unused files#1290
Conversation
Remove one-time rake tasks (Paperclip→ActiveStorage, asset migrations, rich text URL rewrites, data backfills, tag deduping, etc.), dead models (ReportStory, ThumbnailAsset), old _old view templates, image migration audit controller, kt-paperclip gem/initializer, legacy backup script, unused feature_flag_variables.rb, db/init SQL dumps, and stale data files. Move cloudinary_rows.csv to db/. Fix check_feature_flag typo. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove kt-paperclip and its orphaned dependencies (terrapin, climate_control, mime-types, mime-types-data) from the lockfile to fix CI frozen bundle check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Records in the database still have type "ReportStory" so the class file must exist for Rails STI to load them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file loaded paperclip/matchers into RSpec, causing every spec to fail after kt-paperclip was removed. No specs use Paperclip matchers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
kt-paperclipgem and its initializer — no models use Paperclip anymoreReportStory(marked TODO for removal),ThumbnailAsset(orphaned STI class)image_migration_auditcontroller, view, and route_oldview templates (kept Devise ones for reference)bin/backup-db.sh(hardcoded old server hostnames)db/init/SQL dumps (87MB+ of tracked binary data)app/services/workshops_to_revert.json(5.3MB unreferenced data file)config/feature_flag_variables.rband its load lines in dev/test environments (app usesfeature_flippergem instead)cloudinary_rows.csvfromapp/services/todb/check_feature_fag→check_feature_flagtypo inmonthly_reports_controller.rbAnything else to add?
app/services/rich_text_migrator.rbwas kept intentionally — reusable for future Rhino field conversionsapp/services/model_deduper.rbandDedupableconcern are actively used by controllersdb/archived/(172 old migrations) left as-is — intentional archive🤖 Generated with Claude Code