Skip to content

Global spec temp directory setup #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpep wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −21
Open

Global spec temp directory setup #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions spec/singed_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
# frozen_string_literal: true

require "tempfile"

RSpec.describe Singed do
around do |example|
original_output_directory = Singed.output_directory
Singed.output_directory = Dir.mktmpdir("singed-spec")
original_enabled = Singed.enabled?
begin
example.run
ensure
Singed.output_directory = original_output_directory
Singed.enabled = original_enabled
Singed.instance_variable_set(:@current_flamegraph, nil)
end
example.run
ensure
Singed.enabled = original_enabled
Singed.instance_variable_set(:@current_flamegraph, nil)
end

describe ".start" do
Expand Down Expand Up @@ -42,7 +35,6 @@
describe ".stop" do
before do
Singed.enabled = true
Singed.output_directory = Dir.mktmpdir("singed-spec")
end

it "returns nil when not profiling" do
Expand Down
9 changes: 9 additions & 0 deletions spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,17 @@
# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration

require "singed"
require "tmpdir"

RSpec.configure do |config|
config.around do |example|
Dir.mktmpdir("singed-spec") do |dir|
Singed.output_directory = dir
example.run
end
ensure
Singed.output_directory = nil
end
# rspec-expectations config goes here. You can use an alternate
# assertion/expectation library such as wrong or the stdlib/minitest
# assertions if you prefer.
Expand Down
9 changes: 0 additions & 9 deletions spec/support/sidekiq.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require "singed/sidekiq"
require "tempfile"

RSpec.configure do |config|
config.before(:suite) do
Expand All @@ -16,14 +15,6 @@
ActiveJob::Base.queue_adapter = :sidekiq
ActiveJob::Base.logger = Logger.new(nil)
end

config.around(:each, sidekiq: true) do |example|
orig_dir = Singed.output_directory
Singed.output_directory = Dir.mktmpdir("singed-sidekiq-spec")
example.run
ensure
Singed.output_directory = orig_dir
end
end

# Sidekiq doesn't invoke middlewares in inline testingmode, so we need to invoke it oursleves
Expand Down