Skip to content

Explicitly return thread interrupt state in zstream_run_func#74

Closed
ianks wants to merge 3 commits intoruby:masterfrom
ianks:robust-thread-interrupts
Closed

Explicitly return thread interrupt state in zstream_run_func#74
ianks wants to merge 3 commits intoruby:masterfrom
ianks:robust-thread-interrupts

Conversation

@ianks
Copy link

@ianks ianks commented Jan 11, 2024

Previously, there were race conditions checking the interrupt flag when checking whether to retry zstream_run_func. Instead of relying on the volatile args->interrupt state, we now explicitly signal the function returned due to an interrupt so it can be retried safely.

fixes #57

@ioquatix
Copy link
Member

@ianks just curious why you closed this?

@ianks ianks reopened this Feb 27, 2026
@ioquatix
Copy link
Member

Ian, I merged the other PR, sorry, did not mean to cause you extra work. Let's try it and see if we need to iterate again.

@ioquatix ioquatix closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thread#wakeup leads to Zlib::BufError

2 participants