Explicitly return thread interrupt state in zstream_run_func#74
Closed
ianks wants to merge 3 commits intoruby:masterfrom
Closed
Explicitly return thread interrupt state in zstream_run_func#74ianks wants to merge 3 commits intoruby:masterfrom
zstream_run_func#74ianks wants to merge 3 commits intoruby:masterfrom
Conversation
This was referenced Jan 13, 2024
Member
|
@ianks just curious why you closed this? |
Member
|
Ian, I merged the other PR, sorry, did not mean to cause you extra work. Let's try it and see if we need to iterate again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there were race conditions checking the interrupt flag when checking whether to retry
zstream_run_func. Instead of relying on the volatileargs->interruptstate, we now explicitly signal the function returned due to an interrupt so it can be retried safely.fixes #57