Skip overload resolution when splat arguments have uninformative elem…#398
Merged
mame merged 1 commit intoruby:masterfrom Feb 26, 2026
Merged
Skip overload resolution when splat arguments have uninformative elem…#398mame merged 1 commit intoruby:masterfrom
mame merged 1 commit intoruby:masterfrom
Conversation
…ent types The previous fix (ae9dccc) skips overload resolution when positional arguments have no type information. However, splat arguments bypass this check because the positional vertex holds Array types (non-empty) while the array *element* vertex may be empty or conflicting. This causes oscillation: get_rest_args flattens element vertices from all Array types into a single list, and the universal typecheck in match_arguments? fails when elements from different array sources conflict (e.g. Integer from [42] vs String from [@x]). The cycle is: empty elements -> all overloads match -> types flow -> conflicting elements -> no overload matches -> types removed -> empty again. Extend the uninformative-args check to also inspect element vertices of splatted Array types. When any element vertex is empty, skip overload resolution and set up dependency edges, consistent with the existing positional-args fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent types
The previous fix (ae9dccc) skips overload resolution when positional arguments have no type information. However, splat arguments bypass this check because the positional vertex holds Array types (non-empty) while the array element vertex may be empty or conflicting.
This causes oscillation: get_rest_args flattens element vertices from all Array types into a single list, and the universal typecheck in match_arguments? fails when elements from different array sources conflict (e.g. Integer from [42] vs String from [@x]). The cycle is: empty elements -> all overloads match -> types flow -> conflicting elements -> no overload matches -> types removed -> empty again.
Extend the uninformative-args check to also inspect element vertices of splatted Array types. When any element vertex is empty, skip overload resolution and set up dependency edges, consistent with the existing positional-args fix.