Fix constant resolution to prioritize nesting scope over Object ancestors#395
Merged
mame merged 1 commit intoruby:masterfrom Feb 26, 2026
Merged
Conversation
…tors In Ruby's constant lookup, lexical scope (nesting) takes priority over ancestors. However, `resolve` searched all ancestors including Object before checking outer nesting scopes. This caused `include Store` inside `ActiveRecord::Base` to resolve to `::Store` (app model, via Object) instead of `ActiveRecord::Store` (via nesting). Stop ancestor search at Object when outer nesting scopes remain to be checked (cref.outer), while preserving existing behavior for ScopedConstRead which already passes break_object=true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ruby's constant lookup, lexical scope (nesting) takes priority over
ancestors. However,
resolvesearched all ancestors including Objectbefore checking outer nesting scopes. This caused
include StoreinsideActiveRecord::Baseto resolve to::Store(app model, via Object)instead of
ActiveRecord::Store(via nesting).Stop ancestor search at Object when outer nesting scopes remain to be
checked (cref.outer), while preserving existing behavior for
ScopedConstRead which already passes break_object=true.