Fix superclass resolution for class Foo < Foo and add circular inheritance diagnostic#392
Merged
mame merged 1 commit intoruby:masterfrom Feb 25, 2026
Merged
Conversation
…ritance diagnostic When a class is defined with a superclass of the same name (e.g., `class Foo < Foo` inside a module), the superclass constant was incorrectly resolving to the class being defined itself, because TypeProf registers all definitions simultaneously. In Ruby, the superclass expression is evaluated before the class constant is created, so it naturally finds the outer definition. Fix this by using `lenv.cref.outer` for the superclass constant lookup when the superclass is a bare constant with the same name as the class being defined. Also add a diagnostic for circular inheritance detection during install, covering both direct self-reference (`class A < A`) and mutual recursion (`class A < B; class B < A`). Fixes ruby#373 Co-Authored-By: pvcresin <pvcresin0730@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a class is defined with a superclass of the same name (e.g.,
class Foo < Fooinside a module), the superclass constant was incorrectly resolving to the class being defined itself, because TypeProf registers all definitions simultaneously. In Ruby, the superclass expression is evaluated before the class constant is created, so it naturally finds the outer definition.Fix this by using
lenv.cref.outerfor the superclass constant lookup when the superclass is a bare constant with the same name as the class being defined.Also add a diagnostic for circular inheritance detection during install, covering both direct self-reference (
class A < A) and mutual recursion (class A < B; class B < A).Fixes #373