Open
Conversation
I want to start porting this to prism without the translation layer.
Allows to remove some compatibility code with ripper
Earlopain
force-pushed
the
raise-required-ruby-version
branch
from
9e95e61 to
b59e831
Compare
Contributor
Author
|
I saw #210. I'm OK to wait until 3.2 is end of life in a few months. |
Earlopain
force-pushed
the
raise-required-ruby-version
branch
from
b59e831 to
53ca30b
Compare
Collaborator
|
This is a default gem and we need to support all non EOL rubies. We need to wait for 3.2 to go EOL or if it's pressing we can rev major and make a back port branch (just in case). Also, we need to make sure we test with the default prism of Ruby 3.3, which is 0.19.0. |
schneems
reviewed
Jan 28, 2026
Collaborator
schneems
left a comment
schneems
left a comment
There was a problem hiding this comment.
Please add a CI test with the default prism version in 3.3 which is 0.19.0.
Everything else looks good, but will wait for 3.2 to go EOL for merging
Maybe ripper fixed it since then. But prism also doesn't have this problem.
Earlopain
force-pushed
the
raise-required-ruby-version
branch
from
53ca30b to
145d807
Compare
Contributor
Author
|
👍 I added 0.19.0 to CI. As for when to do this, there is no rush. You can merge this whenever it is convenient for you. Definitly no need for backport branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to start porting this to prism without the translation layer. But because it still supports ruby versions that prism can't parse, doing so will be more complicated than needed.
So I propose to drop 3.0, 3.1 and 3.2. Ruby 3.2 already is in security updates only mode and will be completely EOL in about 2 months. So maybe this is ok?
Let me know what you think.