Skip to content

Remove GC.compact from the benchmark harness #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eightbitraptor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove GC.compact from the benchmark harness #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions harness/harness-common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,8 @@ def return_results(warmup_iterations, bench_iterations)
yjit_stats = RubyVM::YJIT.runtime_stats if defined?(RubyVM::YJIT.enabled?) && RubyVM::YJIT.enabled?
zjit_stats = RubyVM::ZJIT.stats if defined?(RubyVM::ZJIT.enabled?) && RubyVM::ZJIT.enabled?

# Full GC then compact before measuring RSS so fragmentation doesn't inflate the number.
# Full GC before measuring RSS to lower GC variance.
GC.start(full_mark: true, immediate_sweep: true)
GC.compact if GC.respond_to?(:compact)

rss = get_rss
ruby_bench_results["rss"] = rss
Expand Down
Loading