-
Notifications
You must be signed in to change notification settings - Fork 450
Enhance search experience for Aliki
#1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
keydown feature to search or unsearch for AlikiAliki
|
This is not a big change. Could you please take a look and review it? |
|
🚀 Preview deployment available at: https://0ccba8f5.rdoc-6cd.pages.dev (commit: db02096) |
|
Thanks for the ideas and PR 😄 I like idea 1, 2, and 5 but am not sure about 3 and 4. On GH, But once they moved to a class/module page, So this is my first concern: the rather complex behaviour will make the feature harder to learn and also harder for future maintenance. My second concern is that we still don't have a good way to showcase available shortcuts to users. I'd like to avoid adding new shortcuts before we solved this problem. Or we risk adding features that'll be in general under-utilised.
I think this should be applied to mobile too. |
|
@st0012 Thank you for your feedback and suggestions. 👍
Not really. Escape can make you quit input area, and then hit / will delete all input. 2026-02-02.134722.mp4
As you can see in the video, this action is not complicated. Just press Escape. Moreover, in the placeholder, it has already indicated that (shift) s is applicable to the current class/module, so people should have a basic expectation. As for maintenance, the main complexity lies in the fact that the desktop and mobile versions have slightly different search interfaces, which may result in some code duplication. However, this is the complexity brought about by the architectural choice. Considering that the main scenario for people to program is still on the desktop, we can temporarily only add this search shortcut for the desktop version.
I think search within the class/module is quite important. In contrast, repeatedly typing out prefix class/module name is annoying. I noticed that you have a high level of concern for the user experience, so you will surely be able to quickly grasp this point.
I've made a new commit. Now it works both on mobile and desktop. |
Since the preview for this PR is no longer available, I'm providing the video to make it easier for all those who can view this PR to review it again, without the need for them to rebuild it themselves.
Now I get it, the current placeholders are indeed not sufficient.
❤️ Don't be so nervous. You don't have to infer the opposite meaning from this sentence. On the contrary, I really like Aliki. Before this, I never used the official documents. So I fully respect your opinion. You can keep this PR in any state you like. Thank you for your work. |
|
I don't plan to stale the PR, just can't accept it as a whole as it is. If you're ok with it, you can submit improvements 1 and 2 in a separate PR and it'll be easier for us to merge it. |


Recently, I have been extensively using the current https://docs.ruby-lang.org/en/master/, I like aliki so much, but I find I want it more convenient to use. So I add/adjust these features:
Escapeto leave search region:to::