Open
Conversation
RUBY_PLATFORM has been "java" on JRuby since the mid 2000s, so use "host_os" from RbConfig::CONFIG to compare the host platform. This fixes installs on FreeBSD and OpenBSD which need to use gmake instead of make.
jeremyevans
reviewed
May 6, 2026
Co-authored-by: Jeremy Evans <code@jeremyevans.net>
Contributor
Author
|
@jeremyevans Thanks for the catch! @kddnewton This can be squashed and merged once green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RUBY_PLATFORM has been "java" on JRuby since the mid 2000s, so use "host_os" from RbConfig::CONFIG to compare the host platform.
This fixes installs on FreeBSD and OpenBSD which need to use gmake instead of make.
cc @jeremyevans who ran into this upgrading minitest while running JRuby on OpenBSD. Please confirm!