♻️ Extract InvalidTaggedResponseError error#687
Merged
Conversation
This converts some instances of `InvalidResponseError` into a subclass: `InvalidTaggedResponseError`. This refactors code that was introduced by #664, which raises an exception when the server sends a tagged `OK` response for a command *before* that command has been fully sent. Please note that the exception class documents more error conditions than are currently handled. It also adds a very simple `Command` data object to encapsulate information that's helpful for this error reporting. Future commits may use these command objects to track the state of active commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts some instances of
InvalidResponseErrorinto a subclass:InvalidTaggedResponseError. This refactors code that was introduced by #664, which raises an exception when the server sends a taggedOKresponse for a command before that command has been fully sent.Please note that the exception class documents more error conditions than are currently handled.
It also adds a very simple
Commanddata object to encapsulate information that's helpful for this error reporting. Future commits may use these command objects to track the state of active commands.