Skip to content

Add obj_need_obj_free_p #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterzhu2118 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

Add obj_need_obj_free_p #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions gc/mmtk/mmtk.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,20 @@ obj_can_parallel_free_p(VALUE obj)
}
}

static bool
obj_need_obj_free_p(VALUE obj)
{
switch (RB_BUILTIN_TYPE(obj)) {
case T_FLOAT:
case T_RATIONAL:
case T_COMPLEX:
case T_OBJECT:
return false;
default:
return true;
}
}

static void
mmtk_flush_obj_free_buffer(struct MMTk_ractor_cache *cache)
{
Expand Down Expand Up @@ -1001,8 +1015,9 @@ rb_gc_impl_new_obj(void *objspace_ptr, void *cache_ptr, VALUE klass, VALUE flags
mmtk_post_alloc_fast_immix(objspace, ractor_cache, (uintptr_t)alloc_obj);
}

// TODO: only add when object needs obj_free to be called
mmtk_buffer_obj_free_candidate(ractor_cache, (VALUE)alloc_obj);
if (obj_need_obj_free_p((VALUE)alloc_obj)) {
mmtk_buffer_obj_free_candidate(ractor_cache, (VALUE)alloc_obj);
}

objspace->total_allocated_objects++;

Expand Down
Loading