Skip to content

Use Prism::ParseResult#continuable? if possible #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tompng wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

Use Prism::ParseResult#continuable? if possible #1184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions lib/irb/ruby-lex.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,22 @@ def should_continue?(tokens, line, line_num)

def check_code_syntax(code, local_variables:)
result = Prism.lex(code, scopes: [local_variables])
return :valid if result.success?
if result.success?
:valid
elsif result.respond_to?(:continuable?)
Copy link
Member

@st0012 st0012 Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment mentioning that we can simplify the conditions when we bumped Prism to a version that continuable? will always be present.

result.continuable? ? :recoverable_error : :unrecoverable_error
else
check_syntax_error_heuristics(result)
end
end

# Prism <= 1.9.0 does not have `ParseResult#continuable?` method.
# Fallback to legacy heuristics based on error messages and error locations.
def check_syntax_error_heuristics(prism_parse_result)

# Get the token excluding trailing comments and newlines
# to compare error location with the last or second-last meaningful token location
tokens = result.value.map(&:first)
tokens = prism_parse_result.value.map(&:first)
until tokens.empty?
case tokens.last.type
when :COMMENT, :NEWLINE, :IGNORED_NEWLINE, :EMBDOC_BEGIN, :EMBDOC_LINE, :EMBDOC_END, :EOF
Expand All @@ -150,7 +161,7 @@ def check_code_syntax(code, local_variables:)
end

unknown = false
result.errors.each do |error|
prism_parse_result.errors.each do |error|
case error.message
when /unexpected character literal|incomplete expression at|unexpected .%.|too short escape sequence/i
# Ignore these errors. Likely to appear only at the end of code.
Expand Down