Skip to content

Fix IRB crash when typing string literal with control/meta sequence #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 1 commit into from
Mar 11, 2026
+7 −0
Merged

Fix IRB crash when typing string literal with control/meta sequence #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/irb/ruby-lex.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def should_continue?(tokens, line, line_num)
t.type != :NEWLINE &&
t.type != :EOF
trailing = line.byteslice(t.location.end_column..)
trailing ||= '' # in case end_line is wrong (e.g. `"\C-`)
break
end
end
Expand Down
6 changes: 6 additions & 0 deletions test/irb/test_irb.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,6 +828,12 @@ def test_dynamic_prompt_with_blank_line
assert_dynamic_prompt(input_with_prompt)
end

def test_dynamic_prompt_with_incomplete_ctrl_meta_sequence_string
assert_dynamic_prompt([['001:0:":* ', %q("\C-)]])
assert_dynamic_prompt([['001:0:":* ', %q("\M-)]])
assert_dynamic_prompt([['001:0:":* ', %q("\C-\M-)]])
end

def assert_dynamic_prompt(input_with_prompt)
expected_prompt_list, lines = input_with_prompt.transpose
def @irb.generate_prompt(opens, continue, line_offset)
Expand Down