Remove unused fu_copy_stream0 helper#170
Open
nvasilevski wants to merge 1 commit into
Open
Conversation
fu_copy_stream0 has had no caller since b26846b replaced both uses with direct IO.copy_stream calls in 2008. The retained private wrapper is unreachable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileUtils::StreamUtils_#fu_copy_stream0is a private, undocumented helper with no callers.Commit b26846b replaced both of its callers with direct
IO.copy_streamcalls in 2008, but retained the wrapper itself. It has been unused ever since.This removes the unreachable helper.
Verification:
bundle exec rake test— 423 tests, 1,135 assertions, 0 failures.