Fix oauth_* accessors to unwrap array values from wrap_values#353
Merged
pboling merged 2 commits intoruby-oauth:mainfrom Apr 2, 2026
Merged
Fix oauth_* accessors to unwrap array values from wrap_values#353pboling merged 2 commits intoruby-oauth:mainfrom
pboling merged 2 commits intoruby-oauth:mainfrom
Conversation
Parameters stored via wrap_values are arrays, but callers expect scalar strings from oauth_timestamp, oauth_nonce, oauth_consumer_key etc. Only oauth_signature had the [...].flatten.first unwrap; all other accessors returned arrays when params came from POST body or query string, causing NoMethodError (e.g. Array#to_i on timestamp). Apply the same unwrap pattern to all oauth_* accessors for consistency.
Base already defines oauth_signature with array-safe unwrapping and aliases it as signature. The override in RackRequest duplicated that logic without the safety, making it a latent bug for array-valued params and a broken inherited method for ActionDispatchRequest which wraps all params via wrap_values.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters stored via wrap_values are arrays, but callers expect scalar strings from oauth_timestamp, oauth_nonce, oauth_consumer_key etc. Only oauth_signature had the [...].flatten.first unwrap; all other accessors returned arrays when params came from POST body or query string, causing NoMethodError (e.g. Array#to_i on timestamp).
Apply the same unwrap pattern to all oauth_* accessors for consistency.