Merged
Conversation
Member
pboling
commented
Nov 7, 2025
- fixes Ruby 3.4 compatibility #342
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 84.27% 84.27%
=======================================
Files 36 36
Lines 1062 1062
Branches 298 298
=======================================
Hits 895 895
Misses 167 167 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds the base64 gem as an explicit runtime dependency to ensure compatibility with Ruby 3.4 and 3.5 HEAD, where base64 is no longer a default gem but a bundled gem that must be explicitly required.
- Adds
base64 (~> 0.1)dependency to the gemspec with an explanatory comment about Ruby version compatibility - Updates Gemfile.lock to reflect the new dependency
- Documents the change in CHANGELOG.md
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| oauth.gemspec | Adds base64 (~> 0.1) as a runtime dependency with a comment explaining it became a bundled gem in Ruby 3.4 |
| Gemfile.lock | Reflects the addition of base64 dependency to the oauth gem specification |
| CHANGELOG.md | Documents the new base64 dependency and its purpose for Ruby 3.4 and 3.5 HEAD compatibility |
| .rubocop_gradual.lock | Updates line numbers for existing RuboCop offenses due to the added lines in oauth.gemspec |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 19155553390Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.