Add a new I18n.isolation_scope= option to explicitly use threads or fibers#730
Closed
travisbell wants to merge 2 commits intoruby-i18n:masterfrom
Closed
Add a new I18n.isolation_scope= option to explicitly use threads or fibers#730travisbell wants to merge 2 commits intoruby-i18n:masterfrom
I18n.isolation_scope= option to explicitly use threads or fibers#730travisbell wants to merge 2 commits intoruby-i18n:masterfrom
Conversation
…ber locals instead of Threads.
Author
|
P.S. I looked into using the value from |
Author
|
Closing in favour of a more complete implementation: #731 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the update on #723 (#724) I18n became incompatible with web servers like Falcon, that serve every request in a new fiber. You can read my comment on that issue for a bit more context.
This PR introduces a new option called
I18n.isolation_scopewhich allows you to configure where you'd like the instance ofI18n::Configto be stored. By default it stays as a thread variable, but it can be changed to use fibers like so:By using
:fiberwe store the config in a fiber localFiber[:i18n_config]instead of thread localThread.current.thread_variable_get.