Fix before_each method to handle nil parameter correctly #2655
+9
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix before_each method to handle nil parameter correctly
Problem
When calling
before_each(nil)to clear the before_each callbacks, aNoMethodErrorwas raised because the code attempted to assignnilto@before_eachinstead of clearing the array.Solution
before_eachmethod inlib/grape/endpoint.rbto properly handle thenilparameter by clearing the@before_eacharray instead of assigningnilspec/grape/endpoint_spec.rbto be more specific about error types (NameErrorvsNoMethodError) and include error message patterns for better test reliabilityChanges
lib/grape/endpoint.rb: Addedelseclause to clear@before_eachwhennew_setupisnilspec/grape/endpoint_spec.rb: Updated error expectations to match specific error types and messagesTesting
All existing tests pass, and the fix ensures that
before_each(nil)correctly clears the callbacks without raising an error.