rtknavi_qt: avoid touching streams for the options box - #926
Open
ourairquality wants to merge 1 commit into
Open
rtknavi_qt: avoid touching streams for the options box#926ourairquality wants to merge 1 commit into
ourairquality wants to merge 1 commit into
Conversation
The options box does not deal with the streams and yet opening the options box applied some operations to the streams. Not clear what this was tried to do but it certainly messed and the stream options, so just remove it. If some operations need to be applied to the streams then is seems more appropriate to do that in the stream boxes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was there a point to this code that is proposed to be removed?
The options box does not deal with the streams and yet opening the options box applied some operations to the streams. Not clear what this was tried to do but it certainly messed and the stream options, so just remove it. If some operations need to be applied to the streams then is seems more appropriate to do that in the stream boxes.