feat(pipe): add command filtering for pipe commands#2032
Open
dsd2077 wants to merge 2 commits into
Open
Conversation
- Introduced a new `command` argument to the `pipe` command to specify the original command that produced stdin, allowing for more precise filter resolution. - Implemented functions to determine the appropriate pipe filter based on the command provided. - Updated the `run` function in `pipe_cmd` to accept an optional command filter. - Added tests to ensure correct parsing and functionality of the new command filtering feature. - Refactored existing code to utilize a new utility function for determining UTF-8 character boundaries.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk pipe --command <command>so pipe mode can choose a more accurate stdin filter from the command that produced the output.--filterprecedence and fall back to output auto-detection when--commandcannot identify a unique filter.Test plan
cargo fmtcargo test pipe_command_filtercargo test pipe_cmdcargo test./target/debug/rtk pipe --command 'rg main'output inspected./target/debug/rtk pipe --command 'cargo test'output inspected