test(permissions): add regression tests for deny/allow mixed chain precedence#2018
Open
okwn wants to merge 2 commits into
Open
test(permissions): add regression tests for deny/allow mixed chain precedence#2018okwn wants to merge 2 commits into
okwn wants to merge 2 commits into
Conversation
When user runs 'git log -1 --format='%H' HEAD' where HEAD is a merge commit, rtk was adding --no-merges which filtered out the merge commit itself and returned the second parent instead. This made 'git log -1' return wrong SHAs for merge commits. Fix: don't add --no-merges when user explicitly passes -n N or --max-count=N. When a user specifies an exact count they expect exactly that many commits, not filtered results. Also skip --no-merges if user already passed --merges or --no-merges explicitly. Fixes rtk-ai#2009.
…ecedence Add 3 tests covering the missing deny/allow mixed chain scenario: - test_chain_deny_short_circuits_allow: single denied segment short-circuits - test_chain_deny_wins_over_partial_allow: deny wins in multi-segment chain - test_chain_deny_wins_over_ask: deny > ask precedence in compound commands These complement existing rtk-ai#1213 tests (which cover allow-only chains) by covering the deny precedence edge cases that were not tested. Fixes: rtk-ai#1213 (precedence documentation gap)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.