Address TODO under importToString#77
Open
wmjoubert wants to merge 6 commits intortfeldman:masterfrom
tandigo:master
Open
Address TODO under importToString#77wmjoubert wants to merge 6 commits intortfeldman:masterfrom tandigo:master
wmjoubert wants to merge 6 commits intortfeldman:masterfrom
tandigo:master
Conversation
Owner
|
Love it! Some thoughts:
Thanks for this! 😄 |
Contributor
Author
|
Could not find a way to re-export a union so created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented it like this since I need it for the project I'm working on. Handles most common cases. Will add a test if you approve. I suspect
NameOrUrishould be moved to Css.elm and possibly renamed toNameOrUrlwith anUrltag instead ofUrito be more inline with the CSS semantics.