support @keyframes {...} (for css animations)#227
support @keyframes {...} (for css animations)#227Warry wants to merge 3 commits intortfeldman:masterfrom
Conversation
| else | ||
| let | ||
| props = | ||
| Preprocess.toPropertyPairs mixins |
There was a problem hiding this comment.
This is kind of brutal: converting a Mixin to properties without warnings.
tests/Animations.elm
Outdated
| \() -> | ||
| stylesheet | ||
| [ keyframes "foo" | ||
| [ ( 0, [ backgroundColor red ] ) |
There was a problem hiding this comment.
alternative suggestion :
keyframes "foo"
[ from [ backgroundColor red ]
, progress 33.3 [ backgroundColor blue ]
, to [ backgroundColor yellow ]
]
|
It's kind of working but now I'd like to understand what you mean about warnings and how you imagine I should deal with them. The hart of the problem is here I think : https://github.com/nomalab/elm-css/blob/master/src/Css/Preprocess/Resolve.elm#L156-L181 where we "resolve" the keyframes. I imagine that I should do a better job at converting |
Warry
changed the title
|
Can someone please give me some feedbacks on this, so that I can complete the work? |
|
Any update on this? Full animation support in elm css would be very good. I can help too. |
|
It seems like a related issue was created #313 |
3 participants
Ongoing work, I'm not entirely sure I'm doing this right. See comments.