fix: missing remote attachments issue#243
Conversation
Kallyan01
changed the title
Kallyan01
changed the title
There was a problem hiding this comment.
Pull request overview
Fixes missing thumbnails for remote (Algolia-hydrated) attachment results in the search UI by carrying thumbnail metadata on mocked remote WP_Post objects and intercepting WordPress image/thumbnail rendering paths to use that metadata.
Changes:
- Adds remote thumbnail plumbing by storing Algolia
thumbnailrecord data on remoteWP_Postobjects. - Hooks into WordPress image/thumbnail/content rendering filters to output remote thumbnail URLs/HTML for negative-ID (remote) posts and attachments.
- Updates PHPStan stubs to model the new dynamic
onesearch_thumbnailproperty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
phpstan/stubs/wordpress-extended.php |
Adds PHPStan typing for the new WP_Post::$onesearch_thumbnail dynamic property. |
inc/Modules/Search/Search.php |
Adds filters + helper logic to render remote thumbnails correctly for search results containing remote/negative-ID posts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ( ! empty( $thumbnail['url'] ) ) { | ||
| $block_content = (string) preg_replace( | ||
| '#(<img[^>]*\bsrc)="[^"]*"([^>]*>)#si', | ||
| '$1="' . esc_url( $thumbnail['url'] ) . '"$2', | ||
| $block_content, | ||
| 1 | ||
| ); | ||
| $block_content = (string) preg_replace( | ||
| '#\s*(?:srcset|sizes)="[^"]*"#', | ||
| '', | ||
| $block_content | ||
| ); | ||
| } |
| $content = (string) preg_replace( | ||
| '#<p\s+class=["\']attachment["\']\s*>.*?</p>#s', | ||
| $attachment_html, | ||
| $content, | ||
| 1 | ||
| ); |
| return [ | ||
| $thumbnail['url'], | ||
| $thumbnail['width'] ?? 0, | ||
| $thumbnail['height'] ?? 0, | ||
| false, | ||
| ]; |
| if ( is_string( $attr ) && ! empty( $attr ) ) { | ||
| $attr_string = ' ' . ltrim( $attr ); | ||
| } |
| if ( is_array( $attr ) ) { | ||
| foreach ( $attr as $name => $value ) { | ||
| if ( 'class' === $name ) { | ||
| $attr_string .= sprintf( ' class="%s"', esc_attr( $value ) ); | ||
| } else { | ||
| $attr_string .= sprintf( ' %s="%s"', esc_attr( $name ), esc_attr( $value ) ); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Ignore the copilot noise for now: this is what I was concerned about:
(Left is the local post, right is the remote)
It's possible that the preg_replace can be fixed to better support other block image attachments, and even switching to the more ideal HTML API could catch even more. But ultimately the use of replacing the image output is always going to be flawed, fragile, and susceptible to edge cases.
As mentioned both in the GH issue and on slack, unless you have a reason otherwise, I think the best way to address the bug will be to:
- Programmatically create a single fictitious attachment at plugin activation (and checking/recreating it when using) and assign that number as the post attachment id instead of a non-existent negative post id. It should be hidden from the UX.
- Use the attachment hooks to swap out the metadata on the attachment to the specific remote file, instead of trying to finagle the post directly.
This way any attachment-related functionality work natively the image routing is an isolated implementation detail.
What
Remote site post thumbnail issue on the search area.
Why
It's impacting search result functionality.
Related Issue(s):
Closes https://github.com/rtCamp/OnePress/issues/73
How
The thumbnails were not loading in the search results because remote posts were assigned negative post IDs. To address this, we intercepted those posts and generated the thumbnail data through filters, ensuring that thumbnails are displayed correctly in the search results.
AI Disclosure
Claude Opus 4.6 ( Research )
Testing Instructions
wp-env.Screenshots
Before:
After:
Additional Info
Checklist