Fix: Wide Alignment + Block Tree Selection by theMasudRana · Pull Request #70 · rtCamp/carousel-kit

theMasudRana · 2026-03-02T11:23:55Z

Bug Fix: Wide Alignment + Block Tree Selection

The Problem

Two issues showed up in the block editor when using the carousel with Wide or Full alignment:

Slides didn't scroll fully. Clicking the arrow button would move the slides, but the transition stopped midway — the previous slide stayed partially visible instead of being fully replaced.
Clicking slides in the List View was unreliable. Sometimes the selected slide just wouldn't appear in the editor.

Both worked perfectly on the frontend — this was editor-only.

Root Cause

For the scroll issue: Embla measures the viewport width once at startup to calculate how far to translate slides. We had disabled its built-in resize watcher (watchResize: false) because Gutenberg's block toolbar popping in/out would cause tiny layout shifts that triggered unwanted recalculations. But that also meant Embla never re-measured when the width actually changed (like switching to Wide alignment), so its math was wrong.

For the List View issue: There was simply no code to tell Embla "scroll to slide 3" when you clicked Slide 3 in the List View. On top of that, Gutenberg's own scrollIntoView() was setting a native scrollLeft on the viewport, which broke Embla's transform-based positioning.

The Fix

Resize: Added a debounced ResizeObserver that only fires when the width changes by more than 1px. This ignores the tiny toolbar shifts but catches real layout changes.
List View selection: Added a store subscription that detects which slide is selected (including clicks on blocks inside a slide). When the selection changes, we scroll Embla to that slide. A scroll event listener resets any native scrollLeft that Gutenberg's scrollIntoView sets.
Observer consolidation: Merged useEmblaResizeObserver and useEmblaQueryLoopObserver into a single useCarouselObservers hook. The two hooks were independently creating a MutationObserver on the same element, which caused a three-step cascade when Query Loop loaded new posts — a ResizeObserver would attach to the new slide just before a full init replaced it, leaving a stray reInit() queued on the fresh instance. The consolidated hook uses one MutationObserver, a fullInitPending flag to suppress resize callbacks during init DOM churn, and a coordinated debounce to prevent the cascade entirely.

Why This Is Safe

The resize observer uses the same debounce + threshold approach that prevents toolbar-induced jitter, so the original reason for disabling watchResize is still handled.
The scroll-to-slide logic is a no-op when you're already on the right slide, so it won't interfere with normal editing.
The native scroll reset is scoped to the .embla viewport div only — it can't affect page scroll or other elements.
The observer consolidation is a coordination-only change — resize and Query Loop detection logic is unchanged, only the plumbing between them is different.

Issue: #69

…ide alignment

gemini-code-assist · 2026-03-02T11:24:13Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves two significant editor-specific issues within the carousel block: slides failing to scroll completely when using Wide or Full alignment, and unreliable selection of slides from the List View. The solution involves integrating a debounced resize observer to ensure the carousel accurately adapts to layout changes and implementing logic to synchronize the carousel's scroll position with the selected block, while also mitigating conflicts with Gutenberg's native scroll behavior.

Highlights

Improved Carousel Responsiveness: Implemented a debounced ResizeObserver that triggers Embla Carousel re-initialization only when the viewport width changes by more than 1px, effectively handling wide/full alignment changes without reacting to minor toolbar-induced layout shifts.
Enhanced Block Tree Selection: Added a store subscription to detect the currently selected slide (including nested blocks) and programmatically scroll the Embla carousel to that slide, resolving issues where selected slides were not reliably displayed in the editor.
Native Scroll Conflict Resolution: Introduced a scroll event listener to reset native scrollLeft and scrollTop values on the Embla viewport, preventing Gutenberg's scrollIntoView from interfering with Embla's transform-based positioning.
Code Refactoring: Extracted resize and mutation observer logic into dedicated React hooks (useEmblaResizeObserver and useEmblaQueryLoopObserver) to improve modularity and maintainability of the main component.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

src/blocks/carousel/useEmblaQueryLoopObserver.ts
- Added a new React hook to observe mutations within Query Loop blocks inside the carousel viewport and trigger Embla re-initialization.
src/blocks/carousel/useEmblaResizeObserver.ts
- Added a new React hook to provide a debounced ResizeObserver for the Embla viewport, triggering reInit only on significant width changes.
src/blocks/carousel/viewport/edit.tsx
- Imported useState, useEmblaResizeObserver, and useEmblaQueryLoopObserver.
- Updated the useSelect hook to track selectedSlideIndex based on block selection, including nested child blocks.
- Introduced emblaApiRef, initEmblaRef, and viewportEl state to manage the Embla instance and observer hooks.
- Integrated the new useEmblaResizeObserver and useEmblaQueryLoopObserver hooks.
- Added a useEffect to scroll Embla to the selectedSlideIndex using requestAnimationFrame to avoid conflicts with Gutenberg's scroll behavior.
- Refactored the main Embla initialization useEffect to delegate resize and mutation observation to the newly created hooks.
- Added a scroll event listener to the viewport to reset scrollLeft and scrollTop to zero, counteracting Gutenberg's native scroll behavior.
- Updated Embla initialization to store the API instance in emblaApiRef and the init function in initEmblaRef for external hook access.

Activity

No human activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively resolves two editor-only bugs in the carousel block related to wide alignment and block tree selection. The solution, which involves a custom debounced ResizeObserver and logic to handle slide selection from the List View, is well-implemented. The refactoring of observer logic into separate hooks is a great improvement for code modularity and maintainability. My review includes suggestions to enhance the robustness of the mutation detection, improve code clarity by removing magic numbers in setTimeout calls, and simplify some logic for better readability.

src/blocks/carousel/useEmblaQueryLoopObserver.ts

src/blocks/carousel/viewport/edit.tsx

…usel

gemini-code-assist · 2026-03-03T05:51:15Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copilot

Pull request overview

Fixes editor-only carousel issues when using Wide/Full alignment and when selecting slides via the List View (block tree), by ensuring Embla re-measures on meaningful width changes and scrolls to the currently selected slide in the editor.

Changes:

Add debounced ResizeObserver + deferred reInit() to keep Embla measurements correct after editor layout/alignment changes.
Subscribe to block-editor selection to scroll Embla to the selected slide (including nested selection), and neutralize Gutenberg’s native scrollLeft/scrollTop interference.
Refactor observer logic into useEmblaResizeObserver and useEmblaQueryLoopObserver hooks.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/blocks/carousel/viewport/edit.tsx	Adds editor selection-driven scrolling, native scroll reset, deferred `reInit()`, and wires in new observer hooks.
src/blocks/carousel/styles/_core.scss	Adds alignment-related width styling for `.alignfull` in the shared block stylesheet.
src/blocks/carousel/hooks/useEmblaResizeObserver.ts	New hook: debounced width-change observer that triggers Embla `reInit()`.
src/blocks/carousel/hooks/useEmblaQueryLoopObserver.ts	New hook: debounced mutation observer for Query Loop slide-count changes that re-initializes Embla.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/blocks/carousel/styles/_core.scss

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T12:55:06Z

src/blocks/carousel/viewport/edit.tsx

 	useEffect( () => {
-		const api = emblaRef.current
-			? ( emblaRef.current as { [ EMBLA_KEY ]?: EmblaCarouselType } )[ EMBLA_KEY ]
-			: null;
-		if ( api ) {
-			setTimeout( () => api.reInit(), 10 );
+		if ( emblaApiRef.current ) {
+			// Defer until after React's commit phase so the new slide DOM is ready.
+			setTimeout( () => emblaApiRef.current?.reInit(), 0 );
 		}
 	}, [ slideCount ] );


The setTimeout used to call reInit() on slide count changes isn’t cleared on unmount or when slideCount changes again. That can fire after Embla has been destroyed and cause a reInit on a stale instance. Store the timeout id and clearTimeout it in the effect cleanup (and/or switch to queueMicrotask/requestAnimationFrame if the goal is just post-commit deferral).

src/blocks/carousel/hooks/useEmblaQueryLoopObserver.ts

src/blocks/carousel/viewport/edit.tsx

…Observer

… fix/editor-width

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/blocks/carousel/viewport/edit.tsx

…dit component

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/blocks/carousel/hooks/useEmblaResizeObserver.ts

src/blocks/carousel/viewport/edit.tsx

…te updates during unmount

…itializations

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/blocks/carousel/hooks/useEmblaQueryLoopObserver.ts

sanketio · 2026-03-11T05:15:37Z

src/blocks/carousel/viewport/edit.tsx

 	const { insertBlock } = useDispatch( 'core/block-editor' );

+	useEmblaResizeObserver( viewportEl, emblaApiRef );
+	useEmblaQueryLoopObserver( viewportEl, initEmblaRef );


useEmblaResizeObserver calls emblaRef.current.reInit() (non-destructive), while useEmblaQueryLoopObserver calls initEmblaRef.current() (full recreate). The two hooks use fundamentally different reinit strategies with no explanation in useEmblaResizeObserver of why a non-destructive reInit is sufficient there but not for Query Loop. If the answer is that Query Loop changes the container DOM structure (requiring a destroy/recreate), that is not commented, making the design choice invisible to future maintainers.

@sanketio, I have made the following changes in my recent commits and added the documentation as needed.

I refactored useEmblaResizeObserver to handle both viewport resizes (alignment changes) and slide resizes (column style changes). Previously, it only watched the viewport, which is why column changes weren't triggering a reInit. Now it observes both the viewport AND the first slide element, using a WeakMap to track widths per-element. When any observed element changes by more than 1px, it triggers reInit.

I've added clarifying JSDoc to both hooks, explaining the different strategies:

useEmblaResizeObserver: Uses reInit() because resize only affects measurements and scroll positions — the DOM structure (container + slides) remains unchanged, so Embla's cached element references stay valid.

useEmblaQueryLoopObserver: Uses full destroy/recreate because Query Loop changes can replace the .wp-block-post-template element or swap out its children entirely. Embla caches references to the container and slide elements on init, so when those DOM nodes are replaced, a fresh instance is required.

…on logic

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/blocks/carousel/hooks/useEmblaResizeObserver.ts

…observations

sanketio · 2026-03-11T09:05:38Z

src/blocks/carousel/hooks/useEmblaQueryLoopObserver.ts

+			debounceTimer = setTimeout( syncIfChanged, QUERY_LOOP_DEBOUNCE_MS );
+		} );
+
+		mutationObserver.observe( viewportEl, {


useEmblaResizeObserver and useEmblaQueryLoopObserver both independently create a MutationObserver on viewportEl with { childList: true, subtree: true }. Every single Gutenberg DOM mutation — including typing inside a block or toolbar UI updates — fires both observers simultaneously. The two then independently start their own debounce timers (50ms and 150ms respectively).

In the specific scenario where Query Loop loads new posts:

useEmblaResizeObserver's MutationObserver fires → 50ms debounce → observeFirstSlide() → attaches ResizeObserver to new first slide.

useEmblaQueryLoopObserver's MutationObserver fires → 150ms debounce → init() (full destroy/recreate of Embla).

The ResizeObserver attached in step 1 now fires because init() replaces the component tree → triggers reInit() 200ms later on the freshly-created instance.

The result is three carousel initializations cascading from one user action. These should be coordinated through a single shared MutationObserver, if possible.

Thanks for the detailed breakdown — the cascade scenario made the bug really clear.

The core issue was that two separate MutationObserver instances were watching the same element and racing against each other. The 50ms vs 150ms debounce gap was essentially a ticking clock that guaranteed the ResizeObserver would attach to the new slide just before the full init replaced it, leaving a stray reInit() queued on a fresh instance.

I've merged useEmblaResizeObserver and useEmblaQueryLoopObserver into a single useCarouselObservers hook. Here's how the coordination works:

One MutationObserver drives everything. Slide observation updates and Query Loop detection both happen inside a single processMutations call behind a 150ms debounce, so there's no more race between two independent handlers.

fullInitPending flag is set before calling initEmblaRef.current() and held open for the full RESIZE_DEBOUNCE_MS window. Any ResizeObserver callback that fires during the init DOM churn hits an early return and is suppressed.

resizeTimer is reused for the suppression window, so the existing cleanup in the return covers it automatically with no extra bookkeeping.

Your three-step cascade is no longer possible — there's only one observer reacting to DOM mutations, and a full init explicitly locks out any resize-triggered reInit() for its entire duration.

…r improved carousel init

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

src/blocks/carousel/viewport/edit.tsx

…erver in useCarouselObservers

src/blocks/carousel/hooks/useCarouselObservers.ts

…nt stale references

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T07:06:38Z

src/blocks/carousel/hooks/useCarouselObservers.ts

+			if ( changed && currentCount === 0 ) {
+				// Template removed or emptied — destroy to avoid stale references.
+				emblaRef.current?.destroy();
+				emblaRef.current = undefined;
+				return false;
+			}


When the Query Loop becomes empty (currentCount === 0), this hook destroys emblaRef.current and sets it to undefined, but it doesn’t also clear the Embla instance stored on the viewport element (via Symbol.for('carousel-system.carousel')) or update editor state (e.g., canScrollPrev/Next, context emblaApi). That can leave the controls reading a destroyed/stale instance and keep nav state enabled even though there are no slides. Consider centralizing Embla teardown in the viewport init effect (so it can also delete the DOM key and reset nav/context state), or pass callbacks/viewport cleanup helpers into the hook so the destroy path fully cleans up all references/state.

* refactor: update changelog script to use npx and remove conventional-changelog-cli dependency - Changed the changelog script in package.json to use npx for conventional-changelog-cli. - Removed conventional-changelog-cli from dependencies in package-lock.json. - Cleaned up unnecessary dependencies related to conventional changelog generation. * chore: update CHANGELOG for version 1.0.1 with bug fixes and new features * chore: remove unused dependency scrivo/highlight.php from composer files * feat: add .distignore file to exclude unnecessary files from WordPress.org distribution * feat: add localization support and update package.json for repository and bugs metadata * feat: add readme.txt with plugin details and installation instructions * feat: update license and version in carousel-kit.php; add index.php for plugin structure * feat: add screenshot for plugin preview in WordPress.org * feat: update .distignore to refine exclusions for WordPress.org distribution * fix(styles): remove unnecessary grid-template-columns property * refactor(styles): improve transition effects and clean up unused properties * fix: CSS linting issues * refactor: Remove unrelated changes from current PR * feat: add placeholder logos and update hero carousel pattern * feat: update .distignore to exclude README.md and enhance carousel-kit.php for direct access protection * feat: Updated pot file * feat: update PHP requirement to 8.2, bump stable tag to 1.0.3, and add changelog entries for fixes * chore: format package.json for consistency in spacing * chore: remove upgrade notice section from readme.txt * chore: remove version field from package.json * feat: update PHP requirement to 8.2 and reorder contributors in plugin header * chore: remove version field from package-lock.json * docs: add link to full changelog in readme.txt * chore: remove version field from package-lock.json * fix: update file paths in phpcs and phpstan configuration * feat: implement autoloader for PHP classes and refactor constant definitions * fix: ignore phpcs warning for including pattern file from a fixed directory * fix: update script paths in composer.json and improve constant definitions in tests * fix: update POT-Creation-Date and add missing autoloader error message * chore: update @wordpress/scripts to version 31.5.0 * feat: add new screenshot image and remove outdated PNG file * fix: clean up .distignore by removing unnecessary files and directories * fix: remove outdated screenshots description from readme * fix: update dist target to exclude additional configuration and development files * fix: ensure direct access to Autoloader.php exits gracefully * fix: update package dependencies for minimatch and serialize-javascript * fix: update script paths in composer.json to use local binaries * feat: update README with minimum requirements and add uninstall functionality * fix: update WordPress minimum requirement to 6.6 in README, INSTALLATION, and readme.txt * fix: update contributors list in plugin header and readme.txt * fix: update package-lock.json to remove unused dependency and upgrade svgo and immutable versions * fix: update tested up to version in readme.txt from 6.9.1 to 6.9 * fix: correct release link in INSTALLATION.md and update node_modules exclusion in phpstan.neon.dist * fix: update @wordpress/scripts version to allow minor updates * chore(release): Prepare v1.0.4 release (#76) * chore: update version to 1.0.4 and enhance readme with changelog details * fix: update stable tag in readme.txt to 1.0.4 * fix: update changelog links to point to the correct repository * fix: update contributors list in README and readme.txt * docs: update Composer installation instructions in INSTALLATION.md * docs: fix formatting in Composer installation instructions in INSTALLATION.md * fix: correct release link format in CHANGELOG.md for version 1.0.1 * fix: remove hardcoded plugin version from Makefile and update installation instructions in INSTALLATION.md * docs: update note on WPackagist availability in INSTALLATION.md Co-authored-by: Utsav Patel <75293077+up1512001@users.noreply.github.com> * Fix: Wide Alignment + Block Tree Selection (#70) * fix: resolve slide translation and Block Tree selection issues with wide alignment * feat: add hooks for observing DOM mutations and resize events in carousel * fix: adjust full and wide alignment styles for carousel container * fix: clarify comment on full alignment breaking out of container * fix: refactor slide count change detection logic in useEmblaQueryLoopObserver * fix: improve slide count detection and optimize viewport scroll handling * fix: add BlockEditorSelectors interface for improved type safety in edit component * fix: ensure viewportEl is set only when node is not null to avoid state updates during unmount * fix: add box-sizing property to ensure no horizontal scroll bar in editor * fix: improve resize observer logic to prevent unnecessary reinitializations * fix: refactor viewportEl state management to prevent unnecessary reinitializations * fix: update documentation for Embla observers to clarify initialization logic * fix: enhance resize observer to track column size changes * fix: improve first slide observation logic to prevent unnecessary re-observations * fix: consolidate resize and mutation observers into a unified hook for improved carousel init * fix: update comment to reflect change from manual debounced ResizeObserver in useCarouselObservers * fix: handle empty template case by destroying Embla instance to prevent stale references Co-authored-by: Aviral Mittal aviral.ideabox@gmail.com Co-authored-by: Vishal Kotak vishalkotak200@gmail.com Co-authored-by: Aishwarrya Pande <169024277+AishwarryaPande@users.noreply.github.com> Co-authored-by: Raj Patel <71687258+imrraaj@users.noreply.github.com> Co-authored-by: Sanket Parmar <7807348+sanketio@users.noreply.github.com> * fix: add direct access protection to example pattern files (#84) Co-authored-by: rtCamp <1128395+rtCamp@users.noreply.github.com> Co-authored-by: Gagan Deep Singh <1535505+gagan0123@users.noreply.github.com> Co-authored-by: Sagar Tamang <8264719+mi5t4n@users.noreply.github.com> Co-authored-by: Aviral Mittal <68884287+aviral-mittal@users.noreply.github.com> Co-authored-by: Vishal Kotak <34092861+vishal4669@users.noreply.github.com> * feat: add new asset images and replace old screenshot (#86) --------- Co-authored-by: Utsav Patel <75293077+up1512001@users.noreply.github.com> Co-authored-by: Aishwarrya Pande <169024277+AishwarryaPande@users.noreply.github.com> Co-authored-by: Raj Patel <71687258+imrraaj@users.noreply.github.com> Co-authored-by: Sanket Parmar <7807348+sanketio@users.noreply.github.com> Co-authored-by: rtCamp <1128395+rtCamp@users.noreply.github.com> Co-authored-by: Gagan Deep Singh <1535505+gagan0123@users.noreply.github.com> Co-authored-by: Sagar Tamang <8264719+mi5t4n@users.noreply.github.com> Co-authored-by: Aviral Mittal <68884287+aviral-mittal@users.noreply.github.com> Co-authored-by: Vishal Kotak <34092861+vishal4669@users.noreply.github.com>

fix: resolve slide translation and Block Tree selection issues with w…

7bb47d1

…ide alignment

gemini-code-assist bot reviewed Mar 2, 2026

View reviewed changes

theMasudRana added 2 commits March 3, 2026 07:45

feat: add hooks for observing DOM mutations and resize events in caro…

4c87580

…usel

fix: adjust full and wide alignment styles for carousel container

c714069

theMasudRana changed the title ~~[WIP] Fix: Wide Alignment + Block Tree Selection~~ Fix: Wide Alignment + Block Tree Selection Mar 3, 2026

theMasudRana self-assigned this Mar 3, 2026

theMasudRana marked this pull request as ready for review March 3, 2026 05:51

theMasudRana requested a review from up1512001 March 3, 2026 07:20

up1512001 requested a review from Copilot March 3, 2026 07:21

Copilot started reviewing on behalf of up1512001 March 3, 2026 07:22 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

src/blocks/carousel/styles/_core.scss Outdated Show resolved Hide resolved

src/blocks/carousel/styles/_core.scss Outdated Show resolved Hide resolved

fix: clarify comment on full alignment breaking out of container

022d87c

up1512001 requested a review from Copilot March 9, 2026 12:50

Copilot started reviewing on behalf of up1512001 March 9, 2026 12:50 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

theMasudRana requested a review from sanketio March 10, 2026 07:22

sanketio reviewed Mar 10, 2026

View reviewed changes

theMasudRana added 2 commits March 10, 2026 15:17

fix: refactor slide count change detection logic in useEmblaQueryLoop…

8fdb47b

…Observer

Merge branch 'develop' of https://github.com/rtCamp/carousel-kit into…

6cd85f3

… fix/editor-width

Copilot AI review requested due to automatic review settings March 10, 2026 09:34

Copilot started reviewing on behalf of theMasudRana March 10, 2026 09:35 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/blocks/carousel/viewport/edit.tsx Outdated Show resolved Hide resolved

theMasudRana added 2 commits March 10, 2026 17:00

fix: improve slide count detection and optimize viewport scroll handling

e0c9f73

fix: add BlockEditorSelectors interface for improved type safety in e…

63f428e

…dit component

Copilot AI review requested due to automatic review settings March 10, 2026 11:44

Copilot started reviewing on behalf of theMasudRana March 10, 2026 11:45 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/blocks/carousel/hooks/useEmblaResizeObserver.ts Outdated Show resolved Hide resolved

src/blocks/carousel/viewport/edit.tsx Outdated Show resolved Hide resolved

fix: ensure viewportEl is set only when node is not null to avoid sta…

7598dc9

…te updates during unmount

fix: refactor viewportEl state management to prevent unnecessary rein…

1df925c

…itializations

Copilot AI review requested due to automatic review settings March 10, 2026 13:03

Copilot started reviewing on behalf of theMasudRana March 10, 2026 13:03 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/blocks/carousel/hooks/useEmblaQueryLoopObserver.ts Outdated Show resolved Hide resolved

theMasudRana requested a review from sanketio March 10, 2026 13:41

sanketio reviewed Mar 11, 2026

View reviewed changes

theMasudRana added 2 commits March 11, 2026 12:00

fix: update documentation for Embla observers to clarify initializati…

cf6541a

…on logic

fix: enhance resize observer to track column size changes

c1d48a2

Copilot AI review requested due to automatic review settings March 11, 2026 08:04

Copilot started reviewing on behalf of theMasudRana March 11, 2026 08:05 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

src/blocks/carousel/hooks/useEmblaResizeObserver.ts Outdated Show resolved Hide resolved

fix: improve first slide observation logic to prevent unnecessary re-…

976e923

…observations

theMasudRana requested a review from sanketio March 11, 2026 08:39

sanketio reviewed Mar 11, 2026

View reviewed changes

fix: consolidate resize and mutation observers into a unified hook fo…

6e726b2

…r improved carousel init

Copilot AI review requested due to automatic review settings March 12, 2026 04:32

Copilot started reviewing on behalf of theMasudRana March 12, 2026 04:32 View session

theMasudRana requested a review from sanketio March 12, 2026 04:33

Copilot AI reviewed Mar 12, 2026

View reviewed changes

src/blocks/carousel/viewport/edit.tsx Outdated Show resolved Hide resolved

src/blocks/carousel/viewport/edit.tsx Show resolved Hide resolved

fix: update comment to reflect change from manual debounced ResizeObs…

d4af80c

…erver in useCarouselObservers

sanketio reviewed Mar 12, 2026

View reviewed changes

src/blocks/carousel/hooks/useCarouselObservers.ts Show resolved Hide resolved

fix: handle empty template case by destroying Embla instance to preve…

f6bc32d

…nt stale references

Copilot AI review requested due to automatic review settings March 12, 2026 07:00

Copilot started reviewing on behalf of theMasudRana March 12, 2026 07:01 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

Copilot AI mentioned this pull request Mar 12, 2026

[WIP] [WIP] Address feedback on wide alignment and block tree selection fixes #82

Closed

sanketio approved these changes Mar 12, 2026

View reviewed changes

rtCamp deleted a comment from Copilot AI Mar 12, 2026

theMasudRana merged commit 13a040b into develop Mar 12, 2026
4 checks passed

Conversation

theMasudRana commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Fix: Wide Alignment + Block Tree Selection

The Problem

Root Cause

The Fix

Why This Is Safe

Uh oh!

gemini-code-assist bot commented Mar 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sanketio Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

theMasudRana Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

sanketio Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

theMasudRana Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

theMasudRana commented Mar 2, 2026 •

edited

Loading