Cleanup hywiki tests after troublehooting#905
Merged
Conversation
rswgnu
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Cleanup hywiki tests after troublehooting.
Why
Removing the initial toggling of hywiki-mode in the test. I think
these lines got added by mistake. They were left as comments with the
intention that they could be uncommented one at a time to trigger
different error situations for trouble shooting the hywiki-mode
transitions. The intention was not to keep all there uncommented.
The current flow is to test with hywiki-mode :all in
hywiki-directory and outside of hywiki-directory. Then test
hywiki-mode :pages in both cases. Finally test hywiki-mode nil in both
cases.
An idea is to extend the test to cover all six possible state
transitions. Or even moving from a state to itself which would mean 9
transitions.