Fix macOS /usr/local/bin ownership: drop -R, restore after install#489
Draft
Fix macOS /usr/local/bin ownership: drop -R, restore after install#489
/usr/local/bin ownership: drop -R, restore after install#489Conversation
|
|
…l/bin ownership after install Co-authored-by: yihui <163582+yihui@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix filesystem security issues in TinyTex installation
Fix macOS Mar 6, 2026
/usr/local/bin ownership: drop -R, restore after install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TinyTeX was recursively changing ownership of
/usr/local/bin(chown -R) — affecting all pre-existing binaries unrelated to TinyTeX — and never reverting the change.Changes
R/install.R—check_local_bin()-Rfromchown: change applies to the directory itself only, not its contentsowner:groupviastat -f '%Su:%Sg'before modifyinginstall_tinytex()registers it viaon.exit()so ownership is restored aftertlmgr path addcompletestools/install-bin-unix.sh-Rremovalowner:groupinPREV_OWNERbeforechown; restore it unconditionally aftertlmgr path addOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.