fix(input_dark_mode): correct light-mode assignment typo in connectedCallback - #1349
Merged
Conversation
…ght preference The existing-light branch in connectedCallback() used `==` instead of `=`, so this.mode stayed undefined and reflectPreference() wrote the literal string "undefined" to data-bs-theme.
cpsievert
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BslibInputDarkMode.connectedCallback()hadthis.mode == "light"(a comparison, not an assignment) in the branch that handles connecting whendocument.documentElementalready hasdata-bs-theme="light".this.modestayedundefined, andreflectPreference()wrote the literal string"undefined"intodata-bs-themeon<html>. The rendered icon still looked correct (Bootstrap has no explicit rule for anything other than[data-bs-theme="dark"]), but the attribute value was invalid and the button'saria-label/titleread "Switch from undefined to light mode" until the first click.==→=) and rebuilt the web-components bundle.Test plan
bslib::page_fillable(bslib::input_dark_mode(style = "display: none"), bslib::input_dark_mode()), confirmdata-bs-themestays"light"(not"undefined") and the visible toggle's label reads "Switch from light to dark mode" on load.