Draft
Conversation
Addresses issue #1292 - adds a download button styled for toolbars. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add base styles and data-type attribute selectors for .bslib-toolbar-download-button to match the existing toolbar input button styling. This includes hover/focus/active states, disabled state, and responsive sizing for label-only, icon-only, and combined icon+label button layouts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adds comprehensive test coverage for toolbar_download_button(): - Basic structure validation (classes, button types) - show_label parameter behavior - disabled state with accessibility attributes - border parameter (border-0 vs border-1) - tooltip parameter (default, custom, and disabled) - custom icon support All tests follow existing patterns from toolbar_input_button() tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix border=TRUE to use Bootstrap's 'border' class instead of 'border-1' (border-1 only sets width, not style) for both toolbar_input_button and toolbar_download_button - Add rel="noopener noreferrer" to target="_blank" anchor tag - Add @examplesIf block to toolbar_download_button docs - Add NEWS.md entry under new "New features" section - Update snapshots to reflect border and rel changes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cpsievert
reviewed
Mar 18, 2026
Comment on lines
+31
to
+42
| receiveMessage(el: HTMLElement, message: ToolbarDownloadButtonMessage) { | ||
| if (hasDefinedProperty(message, "disabled")) { | ||
| if (message.disabled) { | ||
| el.classList.add("disabled"); | ||
| el.setAttribute("aria-disabled", "true"); | ||
| el.setAttribute("tabindex", "-1"); | ||
| } else { | ||
| el.classList.remove("disabled"); | ||
| el.removeAttribute("aria-disabled"); | ||
| el.removeAttribute("tabindex"); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Use Shiny.addCustomMessageHandler("handler1", doAwesomeThing1); instead, see https://shiny.posit.co/r/articles/build/js-send-message/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
toolbar_download_button()to the toolbar component family, providing a download button styled consistently with other toolbar inputs for use in card headers, footers, and other toolbar contexts.Closes #1292
toolbar_download_button()R function that creates an<a>tag with Shiny's download machineryupdate_toolbar_download_button()for dynamically updating the disabled statetoolbar_input_button()patternsUsage
card( card_header( "Flower Data", toolbar( align = "right", toolbar_download_button("download_data", label = "Download") ) ), card_body( reactable::reactable(iris) ) )Test Plan
downloadHandler()