Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions client-src/overlay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,14 @@ const createOverlay = (options: CreateOverlayOptions): StateMachine => {
}, trustedTypesPolicyName);
}

let handleEscapeKey: (event: KeyboardEvent) => void;
/**
* ESC key press to dismiss the overlay.
*/
function handleEscapeKey(event: KeyboardEvent): void {
if (event.key === 'Escape' || event.key === 'Esc' || event.keyCode === 27) {
overlayService.send({ type: 'DISMISS' });
}
}

const hideOverlayWithEscCleanup = (): void => {
window.removeEventListener('keydown', handleEscapeKey);
Expand All @@ -629,15 +636,6 @@ const createOverlay = (options: CreateOverlayOptions): StateMachine => {
show(level, messages, options.trustedTypesPolicyName, messageSource),
hideOverlay: hideOverlayWithEscCleanup,
});
/**
* ESC key press to dismiss the overlay.
*/
handleEscapeKey = (event: KeyboardEvent): void => {
if (event.key === 'Escape' || event.key === 'Esc' || event.keyCode === 27) {
overlayService.send({ type: 'DISMISS' });
}
};

window.addEventListener('keydown', handleEscapeKey);

if (options.catchRuntimeError) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"@hono/node-server": "^2.0.11",
"@microsoft/api-extractor": "^7.58.12",
"@rslib/core": "^0.23.2",
"@rslint/core": "^0.7.1",
"@rslint/core": "^0.8.0",
"@rspack/core": "2.0.0-rc.0",
"@rspack/plugin-react-refresh": "2.0.2",
"@rstest/core": "^0.11.4",
Expand Down
84 changes: 42 additions & 42 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 16 additions & 1 deletion rslint.config.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
import { defineConfig, ts } from '@rslint/core';
import { defineConfig, js, ts } from '@rslint/core';

export default defineConfig([
js.configs.recommended,
ts.configs.recommended,
{
rules: {
'@typescript-eslint/no-explicit-any': 'off',
},
},
{
files: ['tests/**/*'],
rules: {
'@typescript-eslint/no-require-imports': 'off',
'@typescript-eslint/no-unused-expressions': 'off',
'no-undef': 'off',
},
},
{
files: ['example/**/*'],
rules: {
'no-undef': 'off',
},
},
]);
1 change: 1 addition & 0 deletions src/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -907,6 +907,7 @@ class Server<
) {
throw new Error(
'Cannot generate a self-signed certificate because optional peer dependency `selfsigned@^5.0.0` is not installed. Please install it and try again.',
{ cause: error },
);
}

Expand Down