You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes a Windows CI flaky failure in the target e2e test. The test asserted console snapshots right after networkidle0, but worker postMessage logs can arrive slightly later, so the snapshot sometimes missed both Worker said messages. It now polls for the worker messages before snapshotting and keeps the final console snapshot order stable.
Reviewing files that changed from the base of the PR and between 20ade13 and 0173323.
📒 Files selected for processing (1)
tests/e2e/target.test.js
📝 Walkthrough
Walkthrough
The e2e target test file gains a workerConsoleMessages array listing expected worker console strings and a waitForWorkerConsoleMessages async helper that polls the collected consoleMessages array until entries prefixed with Worker said: match the expected ordered sequence. The sortByTerm comparator is updated to use includes(). Two existing multi-compiler webworker test cases (web + webworker default and with devServer: false) now await this helper after page navigation before asserting console message and page error snapshots.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
🧪 Generate unit tests (beta)
Create PR with unit tests
Commit unit tests in branch chenjiahan/fix-target-worker-flake
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a Windows CI flaky failure in the target e2e test. The test asserted console snapshots right after
networkidle0, but workerpostMessagelogs can arrive slightly later, so the snapshot sometimes missed bothWorker saidmessages. It now polls for the worker messages before snapshotting and keeps the final console snapshot order stable.Related Links