Skip to content

test: reduce e2e test runtime #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenjiahan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: reduce e2e test runtime #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8a2064
test: reduce e2e test runtime
chenjiahan Jun 21, 2026
3f98c4a
Merge branch 'main' into chenjiahan/test-performance-optimization
chenjiahan Jun 21, 2026
e148e48
test: stabilize e2e performance tests
chenjiahan Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 73 additions & 35 deletions tests/e2e/client-reconnect.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,72 @@ const config = require('../fixtures/simple-config/rspack.config');
const runBrowser = require('../helpers/run-browser');
const port = require('../helpers/ports-map')['client-reconnect-option'];

const DISCONNECTED_MESSAGE = 'Disconnected!';
const RECONNECT_MESSAGE = 'Trying to reconnect...';
const FAST_RECONNECT_DELAY = 100;

const delay = (ms) => new Promise((resolve) => setTimeout(resolve, ms));

const waitForMessages = async (
consoleMessages,
predicate,
errorMessage,
timeout = 10000,
) => {
const startedAt = Date.now();

while (Date.now() - startedAt < timeout) {
const texts = consoleMessages.map((message) => message.text());

if (predicate(texts)) {
return;
}

await delay(50);
}

throw new Error(errorMessage);
};

const waitForReconnectMessages = (consoleMessages, expectedCount) =>
waitForMessages(
consoleMessages,
(texts) =>
texts.filter((text) => text.includes(RECONNECT_MESSAGE)).length >=
expectedCount,
`Expected ${expectedCount} reconnect messages.`,
15000,
);

const waitForDisconnectMessage = (consoleMessages) =>
waitForMessages(
consoleMessages,
(texts) => texts.some((text) => text.includes(DISCONNECTED_MESSAGE)),
`Expected "${DISCONNECTED_MESSAGE}" message.`,
);

const waitForConsoleMessages = (consoleMessages, expectedCount) =>
waitForMessages(
consoleMessages,
(texts) => texts.length >= expectedCount,
`Expected ${expectedCount} console messages.`,
);

const useFastPageReconnectTimers = async (page) => {
await page.evaluateOnNewDocument((fastReconnectDelay) => {
const originalSetTimeout = window.setTimeout.bind(window);

window.setTimeout = (handler, timeout, ...args) =>
originalSetTimeout(
handler,
typeof timeout === 'number' && timeout >= 1000
? fastReconnectDelay
: timeout,
...args,
);
}, FAST_RECONNECT_DELAY);
};

describe('client.reconnect option', () => {
describe('specified as true', () => {
let compiler;
Expand All @@ -21,6 +87,7 @@ describe('client.reconnect option', () => {
await server.start();

({ page, browser } = await runBrowser());
await useFastPageReconnectTimers(page);

pageErrors = [];
consoleMessages = [];
Expand Down Expand Up @@ -49,21 +116,7 @@ describe('client.reconnect option', () => {
await server.stop();
}

let interval;

await new Promise((resolve) => {
interval = setInterval(() => {
const retryingMessages = consoleMessages.filter((message) =>
message.text().includes('Trying to reconnect...'),
);

if (retryingMessages.length >= 5) {
clearInterval(interval);

resolve();
}
}, 1000);
});
await waitForReconnectMessages(consoleMessages, 5);

expect(pageErrors).toMatchSnapshot('page errors');
});
Expand All @@ -85,6 +138,7 @@ describe('client.reconnect option', () => {
await server.start();

({ page, browser } = await runBrowser());
await useFastPageReconnectTimers(page);

pageErrors = [];
consoleMessages = [];
Expand Down Expand Up @@ -113,16 +167,7 @@ describe('client.reconnect option', () => {
await server.stop();
}

// Can't wait to check for unlimited times so wait only for couple retries
await new Promise((resolve) =>
setTimeout(
() => {
resolve();
},
// eslint-disable-next-line no-restricted-properties
1000 * 2 ** 3,
),
);
await waitForDisconnectMessage(consoleMessages);

expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
'console messages',
Expand All @@ -148,6 +193,7 @@ describe('client.reconnect option', () => {
await server.start();

({ page, browser } = await runBrowser());
await useFastPageReconnectTimers(page);

pageErrors = [];
consoleMessages = [];
Expand Down Expand Up @@ -176,16 +222,8 @@ describe('client.reconnect option', () => {
await server.stop();
}

// Can't wait to check for unlimited times so wait only for couple retries
await new Promise((resolve) =>
setTimeout(
() => {
resolve();
},
// eslint-disable-next-line no-restricted-properties
1000 * 2 ** 3,
),
);
await waitForReconnectMessages(consoleMessages, 2);
await waitForConsoleMessages(consoleMessages, 10);

expect(consoleMessages.map((message) => message.text())).toMatchSnapshot(
'console messages',
Expand Down
Loading