Skip to content

fix: preserve fresh config errors #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jul 11, 2026
Merged

fix: preserve fresh config errors #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions src/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,6 @@ type NativeLoadResult = {

export const JS_CONFIG_REGEXP = /\.(?:js|mjs|cjs)$/;

const tryFreshImport = async (configFileURL: string) => {
try {
const { freshImport } = await import(
/* rspackChunkName: 'freshImport' */
'fresh-import'
);
return await freshImport(configFileURL);
} catch {
//
}
};

export const loadWithNative = async (
configPath: string,
fresh: boolean,
Expand All @@ -33,7 +21,11 @@ export const loadWithNative = async (
};
}

const freshImportResult = await tryFreshImport(configFileURL);
const { freshImport } = await import(
/* rspackChunkName: 'freshImport' */
'fresh-import'
);
Comment thread
chenjiahan marked this conversation as resolved.
const freshImportResult = await freshImport(configFileURL);

if (freshImportResult) {
return {
Expand Down
3 changes: 3 additions & 0 deletions tests/fresh/error.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
globalThis.__freshErrorCount = (globalThis.__freshErrorCount ?? 0) + 1;

throw new Error('test config error');
10 changes: 10 additions & 0 deletions tests/fresh/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { loadConfig } from '../../src/index';
const __dirname = import.meta.dirname;
const configPath = join(__dirname, 'demo.config.mjs');
const depPath = join(__dirname, 'dep.mjs');
const errorConfigPath = join(__dirname, 'error.config.mjs');

test('fresh reloads bypass module cache and report relative dependencies', async () => {
Reflect.deleteProperty(globalThis, '__freshConfigCount');
Expand Down Expand Up @@ -36,3 +37,12 @@ test('fresh reloads bypass module cache and report relative dependencies', async
expect(fresh.dependencies).toEqual([depPath]);
expect(fresher.dependencies).toEqual([depPath]);
});

test('fresh config errors are not retried', async () => {
Reflect.deleteProperty(globalThis, '__freshErrorCount');

await expect(
loadConfig({ path: errorConfigPath, loader: 'native', fresh: true }),
).rejects.toThrow('test config error');
expect(Reflect.get(globalThis, '__freshErrorCount')).toBe(1);
});