Skip to content

Normal subscribers require unsafe urls #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewshell merged 1 commit into from
Apr 8, 2026
Merged

Normal subscribers require unsafe urls #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rsscloud/notification-request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ function rsscloud_hub_process_notification_request( ) {

$challenge = rsscloud_generate_challenge( );

$result = wp_safe_remote_get( $notify_url . '?url=' . esc_url( wp_unslash( $_POST['url1'] ) ) . '&challenge=' . $challenge, array( 'method' => 'GET', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, ) );
$result = wp_remote_get( $notify_url . '?url=' . esc_url( wp_unslash( $_POST['url1'] ) ) . '&challenge=' . $challenge, array( 'method' => 'GET', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, ) );
} else {
if ( false === strpos( $notify_url, 'http://' ) )
$notify_url = 'http://' . $notify_url;

$result = wp_safe_remote_post( $notify_url, array( 'method' => 'POST', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, 'body' => array( 'url' => esc_url_raw( wp_unslash( $_POST['url1'] ) ) ) ) );
$result = wp_remote_post( $notify_url, array( 'method' => 'POST', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, 'body' => array( 'url' => esc_url_raw( wp_unslash( $_POST['url1'] ) ) ) ) );
}

if ( is_wp_error( $result ) )
Expand Down
2 changes: 1 addition & 1 deletion rsscloud/send-post-notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function rsscloud_send_post_notifications( $rss2_url = false ) {
if ( !empty( $url['port'] ) )
$port = $url['port'];

$result = wp_safe_remote_post( $notify_url, array( 'method' => 'POST', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, 'body' => array( 'url' => $rss2_url ) ) );
$result = wp_remote_post( $notify_url, array( 'method' => 'POST', 'timeout' => RSSCLOUD_HTTP_TIMEOUT, 'user-agent' => RSSCLOUD_USER_AGENT, 'port' => $port, 'body' => array( 'url' => $rss2_url ) ) );

do_action( 'rsscloud_send_notification' );

Expand Down
40 changes: 40 additions & 0 deletions tests/test-notification-request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,4 +534,44 @@ function ( $preempt, $args, $url ) {
$notify = rsscloud_get_hub_notifications();
$this->assertArrayHasKey( 'http://callback.example.com:9000/notify', $notify[ $this->feed_url ] );
}

public function test_domain_based_nonstandard_port_not_rejected_by_url_validation() {
// No pre_http_request mock — let the real HTTP layer run so
// wp_http_validate_url is exercised. With a non-standard port,
// wp_safe_remote_get rejects the URL before any network call.
$_POST = array(
'url1' => $this->feed_url,
'port' => '4000',
'path' => '/feedupdated',
'domain' => 'web04.geekity.com',
);

$result = $this->call_process_notification_request();

// The request may fail for network reasons (e.g. connection refused),
// but it must NOT fail because of URL validation.
$this->assertStringNotContainsString(
'A valid URL was not provided',
$result->msg,
'Non-standard port should not be rejected by URL validation.'
);
}

public function test_ip_based_nonstandard_port_not_rejected_by_url_validation() {
// No pre_http_request mock — exercise real URL validation.
$_POST = array(
'url1' => $this->feed_url,
'protocol' => 'http-post',
'port' => '4000',
'path' => '/feedupdated',
);

$result = $this->call_process_notification_request();

$this->assertStringNotContainsString(
'A valid URL was not provided',
$result->msg,
'Non-standard port should not be rejected by URL validation.'
);
}
}
28 changes: 28 additions & 0 deletions tests/test-send-post-notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,4 +274,32 @@ function () use ( &$fired ) {

$this->assertTrue( $fired );
}

public function test_nonstandard_port_not_rejected_by_url_validation() {
// Call the same function the plugin uses to send notifications,
// without mocking HTTP, to verify URL validation accepts non-standard ports.
$url = 'http://web04.geekity.com:4000/feedupdated';
$result = wp_remote_post(
$url,
array(
'method' => 'POST',
'timeout' => 5,
'user-agent' => RSSCLOUD_USER_AGENT,
'port' => 4000,
'body' => array( 'url' => $this->feed_url ),
)
);

// The request may fail for network reasons, but must NOT fail
// due to URL validation rejecting the non-standard port.
if ( is_wp_error( $result ) ) {
$this->assertStringNotContainsString(
'A valid URL was not provided',
$result->get_error_message(),
'Non-standard port should not be rejected by URL validation.'
);
} else {
$this->assertIsArray( $result );
}
}
}
Loading